[HOLD for payment 2024-06-11] [$250] [Xero] An error appears in the console when entering the "Import" menu

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sustinov@applausemail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #41561

Action Performed:

Create a WS and add a XERO account to it

1. Open New Expensify app STG
2. Log in with the prepared account
3. Navigate to the WS settings with the added XERO account
4. Navigate to the Accounting menu
5. Click on "Import" in the XERO settings menu
6. Navigate through the tabs in RHP

Expected Result:

When opening the "Import" menu in the XERO account settings, no errors should appear in the console

Actual Result:

When opening the "Import" menu in the XERO account settings, an error appears in the console

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474983_1715183307297.Recording_PR_41561_Desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015376233957c1d4bf
• Upwork Job ID: 1789036868706181120
• Last Price Increase: 2024-05-10
• Automatic offers:
• c3024 | Reviewer | 0

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[johncschuster]

I agree that this should be in #wave-collect release 2.

cc @zanyrenney just so you know this is an issue 👀

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015376233957c1d4bf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[GoodWork0903]

Hello

[GoodWork0903]

Hi
This error is simple.
Please contact me.

Contributor details
My Expensify account email : solomon21century@outlook.com
Upwork Profile : https://www.upwork.com/freelancers/~01a27ebc4cfff91f79
Thank you for your attention.

[melvin-bot]

@johncschuster, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[johncschuster]

@GoodWork0903 If you would like to solve this issue, please submit a proposal

[GoodWork0903]

Proposal
Please re-state the problem that we are trying to solve in this issue.

✔When you are trying to entering the Import menu, error occur in console✔

What is the root cause of that problem?

✔ This error seems like promise error.✔

What changes do you think we should make in order to solve the problem?

✔First, I have to check your asynchronous functions, I think that there is no difficult problem in here.✔
Thanks

[trjExpensify]

Putting this on everyone's radar @lakchote @rushatgabhane @mananjadhav @hungvu193

[johncschuster]

Thanks for that, @trjExpensify!

[mananjadhav]

I'v raised a PR to fix this. There was a typo in the Routes.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[c3024]

Unassigning myself as this is dealt by others.

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

PR merged into the freeze branch.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: console error on xero customers page. #42324

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

@mananjadhav, can you complete the BZ Checklist when you have a moment? Thank you!

[johncschuster]

Payment Summary:

Contributor: @mananjadhav - $250 - paid via Manual Request
Contributor+: @hungvu193 - Already paid (confirmed via DM)

[rushatgabhane]

@johncschuster xero project had a flat fee. no need to pay per issue on this or other issues

[trjExpensify]

Yep, we can close this!