Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan - the message preview in LHN does not show "Receipt Scan in progress.." #42055

Closed
2 of 6 tasks
m-natarajan opened this issue May 13, 2024 · 33 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@m-natarajan
Copy link

m-natarajan commented May 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.73-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:

Action Performed:

  1. Navigate to a workspace chat as the employee with no previous history
  2. Submit Expense
  3. Notice in the LHN of the workspace chat shows Receipt Scanning.
  4. Go to the request conversation
  5. The request conversation message preview in LHN shows as "$0.00 Expense"

Expected Result:

LHN shows as "Receipt Scan in progress.."

Actual Result:

LHN shows as "$0.00 Expense"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479250_1715600022535.Scan_in_progress.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d67326726a076361
  • Upwork Job ID: 1790110030784376832
  • Last Price Increase: 2024-05-13
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Hourly KSv2 label May 13, 2024
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels May 13, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@m-natarajan
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@arosiclair
Copy link
Contributor

Site is very slow atm so I'm having trouble testing this

@arosiclair
Copy link
Contributor

Reproduced on staging v1.4.73-1. Looks like OpenReport for the expense report is sending the incorrect lastMessageText:

Screenshot 2024-05-13 at 12 37 54 PM

@arosiclair
Copy link
Contributor

Did NOT reproduce in prod v1.4.72-1. OpenReport also still returns the same lastMessageText on prod so that doesn't seem to be the problem actually.

@arosiclair
Copy link
Contributor

I reproduced on staging v1.4.73-1 even while using the prod API so this isn't an API blocker

@arosiclair arosiclair removed the DeployBlocker Indicates it should block deploying the API label May 13, 2024
@arosiclair
Copy link
Contributor

This is not reproducible while offline, but is reproducible on both staging and prod APIs so I'm almost certain this is a bug in Auth. That also makes sense considering nothing in the deploy checklist looks related.

I'm removing the label and putting this in wave-collect.

@arosiclair arosiclair added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01d67326726a076361

@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2024
Copy link

melvin-bot bot commented Jun 3, 2024

@mananjadhav, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

@kadiealexander
Copy link
Contributor

Still reproducible:

2024-06-04_14-48-31.mp4

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 4, 2024
@kadiealexander
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 10, 2024

@mananjadhav, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kadiealexander
Copy link
Contributor

Still not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 11, 2024
@kadiealexander
Copy link
Contributor

Requested a retest here.

@melvin-bot melvin-bot bot removed the Overdue label Jun 14, 2024
@kavimuru
Copy link

Reproducible by the tester

repro.scan.mp4

@melvin-bot melvin-bot bot added the Overdue label Jun 17, 2024
Copy link

melvin-bot bot commented Jun 17, 2024

@mananjadhav, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

@kadiealexander
Copy link
Contributor

Still not overdue!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 18, 2024
Copy link

melvin-bot bot commented Jun 21, 2024

@mananjadhav, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

@kadiealexander
Copy link
Contributor

Still not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 24, 2024
@kadiealexander
Copy link
Contributor

Not overdue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 26, 2024
@kadiealexander
Copy link
Contributor

Closing as this is barely a real-world bug and not reported by a real user. Please feel free to reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
Archived in project
Development

No branches or pull requests

6 participants