Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [$500] Task – Task is bold in LHN when reassign task to another user and @ appears before user name #42068

Closed
1 of 6 tasks
lanitochka17 opened this issue May 13, 2024 · 56 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented May 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.73-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4553777
Email or phone of affected tester (no customers): applausetester+jpcategory@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/

  2. Log in

  3. Open any chat and select Assign task

  4. Create a task and assign to another user

  5. Find task in the LHN

  6. Open task details and reassign task to another user

  7. Observe the task in LHN

Expected Result:

Task details is not bold in LHN when reassign task to another user, as this page is open

Actual Result:

Task details is bold in LHN when reassign task to another user and wait until @ appears before user name in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6479248_1715599916453.bold.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015ad0a78be0f06131
  • Upwork Job ID: 1791203935959134208
  • Last Price Increase: 2024-05-31
  • Automatic offers:
    • getusha | Reviewer | 102709353
    • suneox | Contributor | 102709356
Issue OwnerCurrent Issue Owner: @adelekennedy
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels May 13, 2024
Copy link

melvin-bot bot commented May 13, 2024

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 13, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@bondydaa
Copy link
Contributor

@AndrewGable can you determine if this is something from the API or not? if not can you remove the DeployBlocker label?

@AndrewGable
Copy link
Contributor

Yes, looking into it

@AndrewGable
Copy link
Contributor

I can't figure out which PR introduced the bug 🕵️

@bondydaa - Am I correct that this is the latest diff for Web deploy? https://github.com/Expensify/Expensify/issues/394485

@AndrewGable
Copy link
Contributor

Seems like yes, that was the diff, which should not have caused this, so seems fine to not block on API deploy.

@AndrewGable AndrewGable added Daily KSv2 and removed DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 13, 2024
@AndrewGable
Copy link
Contributor

AndrewGable commented May 13, 2024

Ok can't reproduce bug on production or staging, can we retest this @lanitochka17 ?

Screen.Recording.2024-05-13.at.5.05.52.PM.mov

@lanitochka17
Copy link
Author

Issue is still reproducible

bandicam.2024-05-15.20-45-25-144.mp4

@melvin-bot melvin-bot bot added the Overdue label May 16, 2024
@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2024
@AndrewGable AndrewGable added External Added to denote the issue can be worked on by a contributor Overdue labels May 16, 2024
@melvin-bot melvin-bot bot changed the title Task – Task is bold in LHN when reassign task to another user and @ appears before user name [$250] Task – Task is bold in LHN when reassign task to another user and @ appears before user name May 16, 2024
Copy link

melvin-bot bot commented May 16, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015ad0a78be0f06131

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 13, 2024
@suneox
Copy link
Contributor

suneox commented Jun 15, 2024

Hi @getusha the PR is ready for review

@laurenreidexpensify laurenreidexpensify removed their assignment Jun 18, 2024
@laurenreidexpensify laurenreidexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jun 18, 2024
Copy link

melvin-bot bot commented Jun 18, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 18, 2024
@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Jun 18, 2024
@laurenreidexpensify
Copy link
Contributor

@adelekennedy adding you here for parental leave sub. no action required this BZ this week, PR is still in review, but adding you for payment in coming weeks when the fix makes it to prod. Thanks

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [$500] Task – Task is bold in LHN when reassign task to another user and @ appears before user name [HOLD for payment 2024-07-10] [$500] Task – Task is bold in LHN when reassign task to another user and @ appears before user name Jul 3, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 3, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@suneox / @getusha] The PR that introduced the bug has been identified. Link to the PR:
  • [@suneox / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@suneox / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@suneox / @getusha] Determine if we should create a regression test for this bug.
  • [@suneox / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 10, 2024
@suneox
Copy link
Contributor

suneox commented Jul 12, 2024

Friendly bump @adelekennedy for payment

@adelekennedy
Copy link

Just took care of it! @getusha it looks like your offer is still pending - will yo accept it today? Otherwise it expires!

@getusha
Copy link
Contributor

getusha commented Jul 12, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@suneox / @getusha] The PR that introduced the bug has been identified. Link to the PR: N/a i think this is an edge case left unhandled
[@suneox / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/a
[@suneox / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
[@suneox / @getusha] Determine if we should create a regression test for this bug. I don't think the bug is impactful enough to create a regression test
[@suneox / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/a

@getusha
Copy link
Contributor

getusha commented Jul 12, 2024

Accepted, @adelekennedy, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
No open projects
Archived in project
Development

No branches or pull requests

8 participants