[$250] Clicking on currency in currency selector also scrolls the list.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1715978251152609

Action Performed:

1. Login to https://staging.new.expensify.com/
2. Navigate to settings and select any workspace
3. Click on any other currency to select

Expected Result:

Selects the currency and close the modal.

Actual Result:

It always scrolls the list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-05-18.at.2.01.04.AM.mov

Currency.selector.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0195391e75124d68ce
• Upwork Job ID: 1792684016054362112
• Last Price Increase: 2024-05-20

Issue Owner

Current Issue Owner: @mollfpr

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

It always scrolls the list

What is the root cause of that problem?

• When clicking on a button, three events occur sequentially: onMouseDown, onMouseUp, and onClick.

• In this particular bug scenario, when we initiate a "mouse down" action on option A, it focuses on option A and then scrolls to it. The onMouseDown event's target is option A.

• Since the mouse pointer remains stationary, after the list is scrolled, the pointer ends up over another option, B.

• Subsequently, when we release the mouse button ("mouse up"), the onMouseUp event's target is option B.

What changes do you think we should make in order to solve the problem?

• In here, we should use shouldPreventDefaultFocusOnSelectRow: true or shouldPreventDefaultFocusOnSelectRow={!DeviceCapabilities.canUseTouchScreen()}

What alternative solutions did you explore? (Optional)

• NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0195391e75124d68ce

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MitchExpensify]

Let's fix this!

[tsa321]

Same as #41922

[MitchExpensify]

Ah good catch @tsa321 , closing this dupe