Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Payment card / Subscription] Integrate Retry billing button with backend data #42434

Closed
amyevans opened this issue May 21, 2024 · 29 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@amyevans
Copy link
Contributor

amyevans commented May 21, 2024

Design doc

Issue OwnerCurrent Issue Owner: @MrMuzyk
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011654f2b733a74a09
  • Upwork Job ID: 1805295362253827219
  • Last Price Increase: 2024-06-24
@web-cloudy
Copy link

Hi
Could you give me access?

Copy link

melvin-bot bot commented May 22, 2024

📣 @web-cloudy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@pasyukevich
Copy link
Contributor

Hi, I'm Eugene from Callstack - an expert agency - and I would like to work on this issue.

@amyevans
Copy link
Contributor Author

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label May 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 10, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@amyevans
Copy link
Contributor Author

Reassigning to @blimpich since I'm headed out on extended leave after today

@amyevans amyevans assigned blimpich and unassigned amyevans Jun 14, 2024
@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 18, 2024

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

I want to take over this from Julian as he hasn't started yet and he's taking over some stuff after Eugene :)

@blimpich blimpich assigned MrMuzyk and unassigned JKobrynski Jun 18, 2024
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Jun 19, 2024
@trjExpensify
Copy link
Contributor

Bumped this to Daily priority as we can work on it. :)

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 19, 2024

I'm still implementing it. It is somewhat blocked by #42431 (need some utils, translations, updated components from there) but I've rebased with WIP that Julian is working on atm and Im doing what I can for now.

Tomorrow Im OOO and I will get back to it on friday. Hopefully by then #42431 will get merged and I will be fully unblocked

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 21, 2024

I've implemented what I can for now and left some questions on slack regarding the server response and happy path. PR will most likely be up on monday/tuesday

@blimpich
Copy link
Contributor

blimpich commented Jun 21, 2024

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jun 24, 2024

Draft is up. Diff is much bigger than it will be once PR that is blocking me gets merged.

@blimpich
Copy link
Contributor

Marking this as external so that the GH automations work correctly when the PR is opened for review.

@MrMuzyk
Copy link
Contributor

MrMuzyk commented Jul 1, 2024

Rebased draft PR. Still blocked

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 2, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Payment card / Subscription] Integrate Retry billing button with backend data [HOLD for payment 2024-07-17] [$250] [Payment card / Subscription] Integrate Retry billing button with backend data Jul 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [$250] [Payment card / Subscription] Integrate Retry billing button with backend data [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Payment card / Subscription] Integrate Retry billing button with backend data Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 22, 2024

Issue is ready for payment but no BZ is assigned. @zanyrenney you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

  • Contributor: @MrMuzyk is from an agency-contributor and not due payment
  • Reviewer: @allroundexperts owed $250 via NewDot

BugZero Checklist (@zanyrenney)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1805295362253827219/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jul 22, 2024
@zanyrenney
Copy link
Contributor

Payment Summary

Upwork Job

  • Contributor: @MrMuzyk is from an agency-contributor and not due payment
  • Reviewer: @allroundexperts owed $250 via NewDot - please request via ND.

@melvin-bot melvin-bot bot removed the Overdue label Jul 23, 2024
@mananjadhav
Copy link
Collaborator

@zanyrenney I think we wrongly tagged @allroundexperts here for the payout. This needs to be paid out to me, as I reviewed the PR.

@zanyrenney
Copy link
Contributor

amending!

@zanyrenney
Copy link
Contributor

zanyrenney commented Aug 5, 2024

updated payment summary

Contributor: @MrMuzyk is from an agency-contributor and not due payment
Reviewer: @mananjadhav owed $250 via NewDot - please request via ND.

@JmillsExpensify
Copy link

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
Archived in project
Development

No branches or pull requests