Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-11] [Wave Collect] [Xero] Clean-up the educational messages when connected to QBO/Xero #42456

Closed
lakchote opened this issue May 22, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lakchote
Copy link
Contributor

lakchote commented May 22, 2024

  1. The Categories, Tags and Taxes pages should all have a message that links to Accounting page to manage the integration settings atop the page.
    a. Xero: All three are incorrect: Categories displays the QBO message, Tags and Taxes are missing.
    b. QBO: The message is there for Categories and Tags pages, but missing from the Taxes page.

image

  1. The Organize card in More features should contain a message at the bottom explaining that these features are managed via the integration when connected to an accounting solution and link to Accounting. This is missing when connected to both QBO and Xero.
image
@lakchote lakchote self-assigned this May 22, 2024
@mananjadhav
Copy link
Collaborator

I'll pick this.

@trjExpensify
Copy link
Contributor

Adding this screenshot for point 2 in the OP:
image

@trjExpensify
Copy link
Contributor

This part of 1a will be taken care of here: #42458

Categories displays the QBO message

@mananjadhav
Copy link
Collaborator

@trjExpensify
Copy link
Contributor

Responded!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 22, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 4, 2024
@melvin-bot melvin-bot bot changed the title [Wave Collect] [Xero] Clean-up the educational messages when connected to QBO/Xero [HOLD for payment 2024-06-11] [Wave Collect] [Xero] Clean-up the educational messages when connected to QBO/Xero Jun 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 4, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-11. 🎊

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 10, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Issue is ready for payment but no BZ is assigned. @abekkala you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Jun 11, 2024

Payment Summary

Upwork Job

BugZero Checklist (@abekkala)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@abekkala
Copy link
Contributor

@lakchote Can you gut check me that only @mananjadhav requires payment for this one? (according to Melvin)

I'm not sure why melvin only notes them. If I'm looking at the correct PR for this it seems like s77rt was the Reviewer (not mananjadhav) and they are actually the contributor who created the fix?!

Can I confirm that the payments are actually:

FIX: @mananjadhav [$250]
PR Review: s77rt [$250] (I don't know why they are not assigned to this issue as they would appear to be the PR Reviewer) 🤷🏼‍♀️

@mananjadhav
Copy link
Collaborator

@abekkala No payout for me and @hungvu193. Ours is handled centrally as a flat fee.

There would be a payout for @s77rt for reviewing the PR.

@abekkala
Copy link
Contributor

abekkala commented Jun 11, 2024

PAYMENT SUMMARY:

@s77rt
Copy link
Contributor

s77rt commented Jun 12, 2024

@abekkala Accepted! Thanks!

@abekkala
Copy link
Contributor

@s77rt payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
Archived in project
Development

No branches or pull requests

5 participants