[HOLD for payment 2024-06-05] Existing policy expense chats are not being correctly found when inviting users to policies

[Gonals]

Action Performed:

1. Create a worspace
2. Create a room in that workspace
3. Invite a user that is not in the workspace to the room
4. Invite the user to the workspace

Expected Result:

The user is correctly invited to the workspace and a workspace expense chat is created for them

Actual Result:

The user is not invited to the workspace

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @miljakljajic

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.76-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Correctly find Worspace Expense chats when inviting users #42500

If no regressions arise, payment will be issued on 2024-06-05. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Gonals] The PR that introduced the bug has been identified. Link to the PR: Optimistically create policy expense chats for new members of workspaces #16764
• [@Gonals] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Optimistically create policy expense chats for new members of workspaces #16764 (comment)
• [@Gonals] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@Gonals] Determine if we should create a regression test for this bug. Not needed
• [@Gonals] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[eVoloshchak]

@miljakljajic, apologies for this being so late, I believe I'm owed payment for reviewing #42500