[HOLD for payment 2024-07-10] [$250] Simplify the RootNavigator structure

[mountiny]

Follow up to the ideal navigation project, we have one task to simplify the structure now.

Problem

The problem is the same as described in this issue but for the RootNavigator.
Currently, central pane screens in RootNavigator are wrapped with the central pane navigator. This may be problematic for two reasons:

• Getting information about the actual screen requires more code. It has become visible especially after we migrated to typescript, instead of just getting the route name we have to extract the route from the state or params of the parent navigator.
• More nested navigators mean worse performance.

Solution

In the early implementation of navigation, we used the custom component ThreePaneView. That was the main reason to encapsulate screens with central pane navigators. Now we use StackView for both narrow and wide layouts and the wide layout is achieved using styles.

This allows us to flatten the navigation structure. Now screens from CentralPaneNavigator will be mounted directly in the RootNavigator

This way developing and maintaining navigation should be easier and we should get a slight performance boost.
cc @adamgrzybowski @WojtekBoman

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e857cb7b9e57642a
• Upwork Job ID: 1793573481726357504
• Last Price Increase: 2024-05-23
• Automatic offers:
• hoangzinh | Reviewer | 102432432

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e857cb7b9e57642a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[adamgrzybowski]

@WojtekBoman, @Kicu or I will take care of it

[WojtekBoman]

Hi! I'm working on it :)

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski Eep! 4 days overdue now. Issues have feelings too...

[mountiny]

The PR is still in draft

[JmillsExpensify]

Same as above.

[melvin-bot]

@JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[hoangzinh]

same as above. @WojtekBoman there have been no new git commits/comments since last week. Do you have any updates on the PR? any blockers. Thanks

[WojtekBoman]

same as above. @WojtekBoman there have been no new git commits/comments since last week. Do you have any updates on the PR? any blockers. Thanks

The PR is ready for review, there is one unit tests pipeline that is failing, I'm currently investigating it, but besides that everything is ready

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

This will be ready to be paid soon

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Simplify the RootNavigator structure #42582

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment automatic offer (Reviewer)
• @WojtekBoman does not require payment (Contractor)
• @adamgrzybowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[JmillsExpensify]

@hoangzinh do you mind filling out the BZ checklist?

[mountiny]

@JmillsExpensify this was a new feature/ follow up so no other PR to flag this on.

$250 to @hoangzinh for their review and testing.

[mountiny]

Also no regression test required

[melvin-bot]

@JmillsExpensify, @hoangzinh, @mountiny, @WojtekBoman, @adamgrzybowski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

@hoangzinh the old offer expired so I just sent you a new one.

[hoangzinh]

Accepted. Thanks @JmillsExpensify

[JmillsExpensify]

Awesome thanks! All paid out.