[HOLD for payment 2024-06-13] [$250] QBO - Default vendor toggle switch activation is delayed

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when validating #41627
Version Number: 1.4.75-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Have a Collect workspace with Quickbooks enabled

1. Log in with an expensifail account
2. Navigate to Workspace settings - Accounting - Export - Export company cards as
3. Click on "Export company cards as"
4. Click on "Vendor bill"
5. Click on the "Default vendor" toggle switch
6. Click on it again

Expected Result:

It should be instant.

Actual Result:

Default vendor toggle switch takes 1-2 seconds to activate after interacting with it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6489507_1716475677235.bandicam_2024-05-23_16-37-34-616.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0149d7ffc050a52133
• Upwork Job ID: 1794065232279744512
• Last Price Increase: 2024-05-24
• Automatic offers:
• nkdengineer | Contributor | 102499228

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[hayata-suenaga]

I thought this resulted from the backend issue we're temporarily experiencing, but we should have an optimistic update, so this might be a bug. Let's investigate!

[hayata-suenaga]

by the way, the accounting features are behind the beta, so removing the deploy blocker flag.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Default vendor toggle switch takes 1-2 seconds to activate after interacting with it.

What is the root cause of that problem?

The optimistic data here is wrong, configUpdate is an object that should be spread instead of merging it as a field of config object

App/src/libs/actions/connections/index.ts

Line 132 in 8375abe

configUpdate,

App/src/libs/actions/connections/index.ts

Line 150 in 8375abe

configCurrentData,

What changes do you think we should make in order to solve the problem?

We should spread the configUpdate here

... configUpdate

App/src/libs/actions/connections/index.ts

Line 132 in 8375abe

configUpdate,

and configCurrentData here

... configCurrentData

App/src/libs/actions/connections/index.ts

Line 150 in 8375abe

configCurrentData,

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0149d7ffc050a52133

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Current assignee @hayata-suenaga is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[ShridharGoel]

@thesahindia I think we should be passing policy?.connections?.quickbooksOnline?.config ?? {} in configCurrentData, can you check my proposal as well?

[nkdengineer]

When we call updateManyPolicyConnectionConfigs we only need to update [CONST.QUICK_BOOKS_CONFIG.AUTO_CREATE_VENDOR] and [CONST.QUICK_BOOKS_CONFIG.NON_REIMBURSABLE_BILL_DEFAULT_VENDOR] in config so we don't need to pass policy?.connections?.quickbooksOnline?.config

[ShridharGoel]

But why not just use the config to have complete data?

Also, NON_REIMBURSABLE_BILL_DEFAULT_VENDOR might not be present in the existing config - then we shouldn't be adding it.

[nkdengineer]

But why not just use the config to have complete data?

We use merge method so in failureData so we only need to reset the field that is changed in optimistic data.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@thesahindia this PR is ready for preview

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Default vendor toggle switch activation is delayed #42732

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @thesahindia requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

@thesahindia can you please have the checklist completed at your earliest convenience? This will help avoid any delays in payment early next week. Thanks!

[thesahindia]

It's from #39219. It was a big PR and it's easy to miss such small cases.

I don't think we need a test case for this.

[hayata-suenaga]

I'll be OOO from June 10th to June 13th and will return on Friday. I think I'm not needed anymore, but I just wanted to inform you of my upcoming absence. 😄

[CortneyOfstad]

Payment Summary

@nkdengineer — paid $250 via Upwork
@thesahindia — to be paid $250 via NewDot

Thanks all!

[JmillsExpensify]

$250 approved for @thesahindia