[HOLD for payment 2024-06-28] Push notification Onyx updates are not applied when there is no gap detected

[arosiclair]

Version Number: N/A
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: N/A
Expensify/Expensify Issue URL:
Issue reported by: @arosiclair
Slack conversation: N/A

Action Performed:

1. Log in
2. Accept push notification prompt
3. Kill the app
4. Send yourself a message
5. Verify a push notification appears
6. Enable airplane mode
7. Click the push notification

Expected Result:

The app opens, you're navigated to the chat and the message displays

Actual Result:

The app opens, you're navigated to the chat and the message does NOT display

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[arosiclair]

I described the root of this problem here. I'll open a PR to fix it.

[alitoshmatov]

Removing my assignment since @c3024 reviewed the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix applying onyx updates from push notifications #43056

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $250 C+ @c3024 (Upwork offer here: https://www.upwork.com/nx/wm/offer/102848904)

[c3024]

@MitchExpensify accepted, thanks!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@MitchExpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[arosiclair]

Sounds like this was paid out already. Closing.

[c3024]

@arosiclair

This was not paid out yet. Please keep this open. Thanks!

cc: @MitchExpensify

[c3024]

@MitchExpensify

Bump for payment please!

[arosiclair]

Looks like they're OOO until next week

[MitchExpensify]

Paid! Sorry for the delay