[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] Position 'Track tax' is shifted to the left relative to other data on the settings page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue found around #43182
Version Number: 1.4.80-8
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to URL https://staging.new.expensify.com/

2. Login with any account

3. Create WS if needed

4. Enable Distance Rate -> Settings

5. Put your attention to the position of Track tax

Expected Result:

Track tax item is located on the same level as the others

Actual Result:

Position 'Track tax' is shifted to the left

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6504396_1717710138927.bandicam_2024-06-07_00-21-02-415.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@trjExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Position 'Track tax' is shifted to the left relative to other data on the settings page

What is the root cause of that problem?

We use a horizontal margin styles.mh4 inconsistent with others on the page.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Line 138 in fb562ec

<View style={[styles.mh4]}>

What changes do you think we should make in order to solve the problem?

We will use styles.mh5 as the horizontal margin on the page.

<View style={[styles.mh5]}> 

Alternatively

We can only increase the left margin for the element.

[MonilBhavsar]

cc @nkdengineer @eVoloshchak

[MonilBhavsar]

Not a blocker

[trjExpensify]

@MonilBhavsar can we check it off the deploy checklist then?

[MonilBhavsar]

Yes, done!

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Position 'Track tax' is shifted to the left relative to other data on the settings page

What is the root cause of that problem?

The track tax item currently uses the View component with styles that are inconsistent with the UnitSelector and CategorySelector components.

App/src/pages/workspace/distanceRates/PolicyDistanceRatesSettingsPage.tsx

Lines 125 to 158 in 4fcc5a9

	<OfflineWithFeedback errorRowStyles={styles.mh5}>
	<View style={[styles.mt2, styles.mh4]}>
	<View style={[styles.flexRow, styles.mb2, styles.mr2, styles.alignItemsCenter, styles.justifyContentBetween]}>
	<Text style={[styles.textNormal, styles.colorMuted]}>{translate('workspace.distanceRates.trackTax')}</Text>
	<Switch
	isOn={isDistanceTrackTaxEnabled}
	accessibilityLabel={translate('workspace.distanceRates.trackTax')}
	onToggle={onToggleTrackTax}
	disabled={!isPolicyTrackTaxEnabled}
	/>
	</View>
	</View>
	{!isPolicyTrackTaxEnabled && (
	<View style={[styles.mh4]}>
	<Text
	style={styles.colorMuted}
	fontSize={14}
	>
	{translate('workspace.distanceRates.taxFeatureNotEnabledMessage')}
	<TextLink
	fontSize={14}
	onPress={() => {
	Navigation.dismissModal();
	Navigation.navigate(ROUTES.WORKSPACE_MORE_FEATURES.getRoute(policyID));
	}}
	>
	{translate('workspace.common.moreFeatures')}
	</TextLink>
	{translate('workspace.distanceRates.changePromptMessage')}
	</Text>
	</View>
	)}
	</OfflineWithFeedback>
	</View>

Hence, the track tax item does not match the rest

Also, having a different font structure and behaves differently from the rest.

What changes do you think we should make in order to solve the problem?

We should use the MenuItemWithTopDescription component instead of the View component with some styles in case it doesn't match the rest.

Furthermore, this will allow the track tax item to be highlighted when hovered.

[kavimuru]

Issue is fixed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix distance tax regression #43246

If no regressions arise, payment will be issued on 2024-06-18. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix distance tax regression #43246

If no regressions arise, payment will be issued on 2024-06-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
• [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@MonilBhavsar] Determine if we should create a regression test for this bug.
• [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: