Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] hermesc fails on ~50% of Android builds #44050

Closed
AndrewGable opened this issue Jun 19, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

AndrewGable commented Jun 19, 2024

Problem

Our Android CI/CD builds fail ~50% of the time when building Android since enabling New Architecture.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:createBundleProductionReleaseJsAndAssets'.
> A problem occurred starting process 'command '/home/runner/work/App/App/node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/hermesc''

Latest build failure: https://github.com/Expensify/App/actions/runs/9588292696/job/26440031076

Raw Logs: 10_Run Fastlane beta.txt

We think we've confirmed that this can still happen without any caches enabled, but we are open to trying removing caching or any intermediate steps to try to reduce the number of failures. We usually are able to get it to build successfully on the second or third build try.

Solution

Fix it!

cc @WoLewicki @j-piasecki

@AndrewGable AndrewGable added the Daily KSv2 label Jun 19, 2024
@AndrewGable AndrewGable self-assigned this Jun 19, 2024
@WoLewicki
Copy link
Contributor

Commenting

@AndrewGable AndrewGable assigned WoLewicki and unassigned AndrewGable Jun 20, 2024
@j-piasecki
Copy link
Contributor

Commenting too

@WoLewicki
Copy link
Contributor

Seems like we found a similar issue: facebook/react-native#44952. We'll try to find out if it needs to be upstreamed or added locally to our App.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@AndrewGable
Copy link
Contributor Author

We CP-ed this and it's working, we will reopen if there are any further issues.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 25, 2024
@melvin-bot melvin-bot bot changed the title hermesc fails on ~50% of Android builds [HOLD for payment 2024-07-02] hermesc fails on ~50% of Android builds Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 25, 2024
Copy link

melvin-bot bot commented Jun 25, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.1-19 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-02. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 3, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-02] hermesc fails on ~50% of Android builds [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] hermesc fails on ~50% of Android builds Jul 3, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants