Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HybridApp] Show/Hide "Try New Expensify" button on HybridApp depending on logic with the tryNewDot NVP #44793

Closed
trjExpensify opened this issue Jul 4, 2024 · 1 comment
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@trjExpensify
Copy link
Contributor

trjExpensify commented Jul 4, 2024

Coming from here.

Problem

On August 1st when we release HybridApp, the "Try New Expensify" button will be visible to all users in HybridApp. NewDot isn't quite ready for all existing users just yet though, whether that be due to performance and quality initiatives we're still working on, or functionality not yet built to accommodate their use case.

Why is this important?

We're focusing on new users first for a reason. As a testing bed to iron out the kinks before we turn our focus to existing customer migration. We want to set a good first impression when we do that, and prematurely promoting a path to NewDot prominently in the hamburger menu on mobile (the primary platform of our largest user segment) undermines that strategy.

Solution

Conditionally show the "Try New Expensify" button in the HybridApp based on following logic:

  • anyone that doesn't have the tryNewDot NVP (most users) will see no "Try New Expensify" button
  • anyone who has classicRedirect.dismissed === false is taken straight to NewDot in HybridApp
  • anyone who has classicRedirect.dismissed === true is taken straight to OldDot and sees the "Try New Expensify" button

CC: @AndrewGable @JmillsExpensify @puneetlath @Julesssss. Andrew, I've co-assigned this to you for the time being. Feel free to put it where it needs to go in HybridApp phases.

@trjExpensify trjExpensify added Weekly KSv2 NewFeature Something to build that is a new item. labels Jul 4, 2024
Copy link

melvin-bot bot commented Jul 4, 2024

Current assignee @trjExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@trjExpensify trjExpensify added the Internal Requires API changes or must be handled by Expensify staff label Jul 4, 2024
@AndrewGable AndrewGable assigned Julesssss and unassigned Julesssss Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

3 participants