[HOLD for payment 2024-07-17] Categories - The subtitle under "Members must categorize all expenses" contains "undefined"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click Settings.

Expected Result:

The subtitle under "Members must categorize all expenses" will not contain "undefined".

Actual Result:

The subtitle under "Members must categorize all expenses" contains "undefined".
"Require a category on every expense in order to export to undefined."

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533029_1720092955253.bandicam_2024-07-04_19-34-38-797.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories - The subtitle under "Members must categorize all expenses" contains "undefined"

What is the root cause of that problem?

Undefined is shown when current policy does not have any connection.

App/src/pages/workspace/categories/WorkspaceCategoriesSettingsPage.tsx

Lines 27 to 29 in 2784712

	const currentConnectionName = PolicyUtils.getCurrentConnectionName(policy);
	const toggleSubtitle = `${translate('workspace.categories.needCategoryForExportToIntegration')} ${currentConnectionName}.`;

What changes do you think we should make in order to solve the problem?

Show a different subtitle when policy does not have any connection. We can create one or use categories.subtitle. Or we can just make the subtitle empty when there is no connection. The same should be done on other pages where we use PolicyUtils.getCurrentConnectionName(policy)

What alternative solutions did you explore? (Optional)

[tgolen]

@Krishna2323 I think we should use categories.requiresCategory ("Members must categorize all expenses") if there is no connection. What do you think? Seems like it makes sense to me.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[Krishna2323]

@tgolen, yes we can use that instead, makes sense. workspace.categories.requiresCategory is already used as title, I think we just need to remove the subtitle if there is no connection.

[allgandalf]

This is a deploy blocker, what is the offending PR @Krishna2323 ?

[Krishna2323]

@allgandalf #44664

[tgolen]

we just need to remove the subtitle if there is no connection.

Perfect, this is fine. Thanks! I'll assign you

[allgandalf]

ummm, I agree with @Krishna2323, we should not show any subtitle if we do not have any connection, @tgolen what do you think ?

[mountiny]

This was CPed and the PR is pending validation in staging

[allgandalf]

@mountiny can you update the title to hold for payment please

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Categories - The subtitle under 'Members must categorize all expenses' contains 'undefined'. #44866

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment (Needs manual offer from BZ)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix: Categories - The subtitle under 'Members must categorize all expenses' contains 'undefined'. #44866

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment (Needs manual offer from BZ)
• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[allgandalf]

• The PR that introduced the bug has been identified. Link to the PR: [#Wave-Control: Add NetSuite]: Fix Connection name on Workspace pages. #44664

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44664/files#r1678866912

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Select a workspace with an integration from workspace page > Categories
2. Click Settings > Verify Require a category on every expense... is shown
3. Select a workspace with no integration from workspace page > Categories
4. Click Settings > Verify no subtitle is shown below switch

Do we agree 👍 or 👎

[allgandalf]

Note

@zanyrenney , this is ready for payment, the payment date is wrong, idk why melvin is acting so weird lately, so the payment date was actually 15th, can you pay this out please, thanks

[zanyrenney]

okay thanks @allgandalf

[zanyrenney]

@allgandalf @Krishna2323 please accept job offer via upwork!

[zanyrenney]

https://www.upwork.com/jobs/~01bb053c1f7f26c8bd

[allgandalf]

Applied from my side 👍

[zanyrenney]

payment summary

@Krishna2323 requires payment (Needs manual offer from BZ) - paid $250 via Upwork
@allgandalf requires payment (Needs manual offer from BZ) - paid $250 via Upwork

[zanyrenney]

payments complete, and regression test requested!