[HOLD for payment 2024-07-24] [$250] [Payment card / Subscription] When clicking "Change payment", past data still shows on new form

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.4-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Found when executing PR : #44361
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Access staging.new.expensify.com
2. Sign into a valid account (Beta enabled)
3. Access https://staging.new.expensify.com/settings/subscription/add-payment-card
4. Input valid card data
5. Click on "Change Payment" after the card data has been set

Expected Result:

User expects that if the fields are cleared, then all fields should be cleared.

Actual Result:

The expiration date still shows from the previous card (And is in the correct format, missing a digit) and the Zip code is still showing as well.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533470_1720126583755.Fields_are_still_displaying.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f36eea0f55c219c3
• Upwork Job ID: 1809282474389988839
• Last Price Increase: 2024-07-05

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@mallenexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[mountiny]

This is minor and subscriptions in ND is still hidden for new users so we can demote

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f36eea0f55c219c3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Past data shows in the form when we try to change payment card or opening the add payment card page directly

What is the root cause of that problem?

In the PaymentCard component, we are setting the payment card form with the previously added card details. Due to that some of the fields are populated with the existing card data.

App/src/pages/settings/Subscription/PaymentCard/index.tsx

Lines 48 to 55 in c5eafd3

	useEffect(() => {
	if (!defaultCard?.accountData || isEmptyObject(defaultCard?.accountData)) {
	setShouldShowPaymentCardForm(true);
	return;
	}
	PaymentMethods.setPaymentCardForm(defaultCard.accountData);
	setShouldShowPaymentCardForm(true);
	}, [defaultCard?.accountData]);

What changes do you think we should make in order to solve the problem?

I don't think we need this(setPaymentCardForm) method or don't need to set payment card form details. We can get rid of that useEffect block. Also we need to remove the prop shouldShowPaymentCardForm bcoz it should be always true for web.
Reason - We don't have any edit card functionality for which we need to populate the existing details and for currency updation we use fundList to derive default card currency.

App/src/pages/settings/Subscription/PaymentCard/ChangeBillingCurrency/index.tsx

Line 36 in c5eafd3

initialCurrency={defaultCard?.accountData?.currency}

[blimpich]

Yeah we don't care about them putting in the same card number. Lets keep it simple 👍

[blimpich]

Looks like automation didn't work for automatically assigning the contract. @Pujan92 please feel free to raise a PR. @mallenexpensify will make sure you get paid.

[Pujan92]

@blimpich I will raise PR soon, the contract isn't assigned bcoz now I am about to get payments via Newdot.

[mallenexpensify]

Noting that assign date is after eligible date, so @Pujan92 will be paid via NewDot

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #45334

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 does not require payment (Contractor)
• @fedirjh requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92 / @fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92 / @fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92 / @fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92 / @fedirjh] Determine if we should create a regression test for this bug.
• [@Pujan92 / @fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[fedirjh]

BugZero Checklist:

• Link to the PR: N/A, this is a feature request
• Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

1. Open App
2. Go to /settings/subscription/add-payment-card
3. Enter valid card details and add it
4. Verify the card data has been successfully added to your account
5. Click on "Change Payment" option 
6. Verify previously added card details doesn't show in the form

• Do we agree 👍 or 👎

[mallenexpensify]

@Pujan92 does not require payment (Contractor)

@Pujan92 this should be fixed now to denote you're paid via NewDot. Comment here if you see any assigned issues from today forward where it's not.

@fedirjh , thanks for test case steps

• https://github.com/Expensify/Expensify/issues/414485

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @Pujan92 owed $250 via NewDot
• Reviewer: @fedirjh owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1809282474389988839/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

@mallenexpensify can you confirm the checklist above so I can approve payments?

[melvin-bot]

@Pujan92, @blimpich, @mallenexpensify, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Contributor: @Pujan92 due $250 via NewDot
Contributor+: @fedirjh due $250 via NewDot

Thanks!

[JmillsExpensify]

$250 approved for @fedirjh