-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report fields - Blank list is shown briefly after deleting all report fields #44983
Comments
Triggered auto assignment to @francoisl ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Report fields - Blank list is shown briefly after deleting all report fields What is the root cause of that problem?We aren't checking for pending state like we do in tags and category page. What changes do you think we should make in order to solve the problem?Add similar check in const hasVisibleTag = Object.values(filteredPolicyFieldList).some((tag) => tag.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || isOffline); What alternative solutions did you explore? (Optional) |
This is probably from #44493, not going to block on this as it's not breaking anything. |
Current assignee @mountiny is eligible for the DeployBlockerCash assigner, not assigning anyone new. |
The report fields is behind beta still |
Hello, Im Artem and would like to help with this issue! |
PR reviewed and merged |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.5-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The report field page will show the empty state screen immediately (like it does on Categories and Tags page)
Actual Result:
The report field shows blank first briefly before showing empty state screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6535972_1720449739031.20240708_223735.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: