[HOLD for payment 2024-08-09] [$250] Android - Accounting-Confirm button doesn't work while keyboard is up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Issue found when executing PR #44921

Action Performed:

Pre-requisite

• Collect workspace with accounting enabled
• NetSuite beta enabled for the user. (Use expensifail account)
• Setup NetSuite in OldDot

1. Open the app with the pre-setup workspace
2. Go to Accounting
3. Tap on the Advanced button
4. Tap on Reimbursable expense option (Enable Custom form ID to access this field)
5. Tap inside the input field and type something
6. Tap on Confirm
7. Do step 5 and 6 for Non-reimbursable expense option as well

Expected Result:

Confirm button saves the input value regardless of the keyboard open state

Actual Result:

Confirm button doesn't work while the soft keyboard is in open state

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6538085_1720627955595.Screen_Recording_20240710_190649_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01223454e1811195b9
• Upwork Job ID: 1811119420448681401
• Last Price Increase: 2024-07-10
• Automatic offers:
• hoangzinh | Reviewer | 103068524
• shubham1206agra | Reviewer | 103068526

Issue Owner

Current Issue Owner: @hoangzinh

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[luacmartins]

Seems to come from #44921

[luacmartins]

I don't think this needs to be a blocker since the button still works, just not when the virtual keyboard is active. Tagging the author and reviewers of the original PR to investigate this issue @shubham1206agra @mananjadhav @yuwenmemon

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01223454e1811195b9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[mananjadhav]

@shubham1206agra and I will take care of this. You can assign this to us. Also this is behind beta so not a deploy blocker.

cc - @yuwenmemon

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[luacmartins]

Done!

[luacmartins]

@shubham1206agra is there something blocking the view and thus the press? Maybe there's an invisible element there.

[shubham1206agra]

@shubham1206agra is there something blocking the view and thus the press? Maybe there's an invisible element there.

@luacmartins I don't think that's the case here, as I tried the same on mWeb, and it seems to work fine.

[luacmartins]

hmm then it seems to be an issue with RN itself. Maybe strict mode?

[shubham1206agra]

The problem is that it doesn't happen anywhere else.

[luacmartins]

hmm then maybe it is a problem with the new code 😄

[kabeer95]

Issue Report: Accounting - Confirm Button Not Functional with Keyboard Open on Expensify

Summary:

The "Confirm" button in the Accounting section of Expensify is not responding to clicks when the keyboard is open on mobile devices. This issue hinders users from completing the accounting process, leading to frustration and potential errors.

Reproduction Steps:

Open Expensify on a mobile device.
Navigate to the Accounting section.
Open the keyboard to enter or edit accounting information.
Attempt to click the "Confirm" button while the keyboard is still open.
Expected Result:

The "Confirm" button should respond to clicks and complete the accounting process.

Actual Result:

The "Confirm" button does not respond to clicks, and the accounting process cannot be completed.

Proposed Solution:

To resolve this issue, we recommend implementing one of the following solutions:

Disable keyboard when clicking the Confirm button: Automatically close the keyboard when the user clicks the "Confirm" button, ensuring the button is clickable.
Make the Confirm button keyboard-agnostic: Modify the button's functionality to work independently of the keyboard state, allowing users to click the button even when the keyboard is open.
Estimated Development Time:

We estimate 30 hours to implement the chosen solution and resolve this issue.

Benefits:

Resolving this issue will improve the overall user experience, reduce frustration, and increase the efficiency of the accounting process on Expensify.

Please let us know if you would like to discuss this issue further or proceed with the proposed solution.

[cdOut]

Hi, I'm Tymoteusz from Software Mansion, the expert agency, and I'll be working on this issue.

[cdOut]

Turns out to be a very simple fix. The keyboard doesn't act correctly if the wrapper ConnectionLayout has the attribute shouldUseScrollView set to true. This seems like it has been a simple overlook while implementing the NetSuiteCustomFormIDPage.

I've set the attribute to false since this page does not require it, and it works properly now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NetSuite] Android - Accounting-Confirm button doesn't work while keyboard is up #46405

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @shubham1206agra requires payment automatic offer (Reviewer)
• @cdOut does not require payment (Contractor)

[shubham1206agra]

No payment required here.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @dylanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!