[HOLD for payment 2024-08-01] Thread - Error shows up when user sends a message after leaving the thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any chat
3. Send a message
4. Right click on the message > Reply in thread
5. Send a reply in thread
6. Click on the chat header
7. Click Leave
8. Send a message

Expected Result:

User will be able to send a message

Actual Result:

Error "You don't have access to this chat room." shows up when user sends a message after leaving the thread.
You don't have access to this chat room.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547680_1721434121485.thread.mp4

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[mountiny]

In production you are not able to leave the thread from the RHP

[mountiny]

cc @bernhardoj I think this is coming from your PR #45136 @akinwale

I believe user has to be navigated to the parent chat when they leave a thread, so that they have to join it again by OpenReport when they want to post new messages

[mountiny]

And it seems like its a combination with #45370 cc @dominictb @thesahindia

[francoisl]

This is also fixed by reverting #45370 for me locally.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: allow user to stay in room report screen" #45921

If no regressions arise, payment will be issued on 2024-08-01. 🎊

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@roryabraham Huh... This is 4 days overdue. Who can take care of this?