[HOLD for payment 2024-08-01] [LOW] [Performance] Improve the performance of getDisplayNameForParticipant

[mountiny]

Problem

In the logs and profile traces from Jason's iOS app use, we can see that the getDisplayNameForParticipant method is taking a lot of processing time, forming a bottleneck.

Solution

Work on improving the performance of this method getDisplayNameForParticipant. The proposed solution from Callstack is to cache the phone number formatting

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: improve getDisplayNameForParticipant performance #45907

If no regressions arise, payment will be issued on 2024-08-01. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allgandalf] The PR that introduced the bug has been identified. Link to the PR:
• [@allgandalf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allgandalf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allgandalf] Determine if we should create a regression test for this bug.
• [@allgandalf] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[johncschuster]

Payment Summary:

Contributor+: @allgandalf owed $250 via NewDot

[allgandalf]

I am paid via Upwork @johncschuster

[mountiny]

Nice so no checklist for this one and @allgandalf is paid on Newdot and we got a summary so we can close, thanks everyone!