Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android & iOS - Composer - Selected emoji is not shown in the composer after sending message #46024

Closed
2 of 6 tasks
lanitochka17 opened this issue Jul 23, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jul 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.11-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to DM
  3. Tap on the emoji picker
  4. Select an emoji and send it
  5. Tap on the emoji picker
  6. Select another emoji

Expected Result:

The selected emoji will be shown in the composer

Actual Result:

The selected emoji is not shown in the composer after sending message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6550547_1721742749885.ScreenRecording_07-23-2024_21-15-40_1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment DeployBlocker Indicates it should block deploying the API labels Jul 23, 2024
Copy link

melvin-bot bot commented Jul 23, 2024

Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@rlinoz
Copy link
Contributor

rlinoz commented Jul 23, 2024

Removing the Web-E blocker label, since this is on the app composer.

@rlinoz rlinoz removed the DeployBlocker Indicates it should block deploying the API label Jul 23, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jul 23, 2024

It looks like it is caused by #45613

cc: @hannojg @Ollyws

@hannojg
Copy link
Contributor

hannojg commented Jul 23, 2024

Might have been caused by my PR, will take a look tmrw, feel free to assign me!

Interesting side note: you can still press send and the emojis will be send to chat, its just that the composer seem to be stuck

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Jul 23, 2024
@rlinoz
Copy link
Contributor

rlinoz commented Jul 23, 2024

We CP'd the revert and it fixed the issue.

@rlinoz
Copy link
Contributor

rlinoz commented Jul 24, 2024

Let's close this one since the issue is fixed by the revert.

@rlinoz rlinoz closed this as completed Jul 24, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants