Contact Method – Received email twice when add new Contact Method

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4808025
Email or phone of affected tester (no customers): applausetester+jp_e_category_2@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Navigate to account settings > Profile
4. Click on "Contact Method"
5. Click on "New Contact method"
6. Add a email you have access to
7. Go back to the contact method list and click on the previously added email
8. Open email and observe number of new messages for this account
9. Copy the Magic Code included in the validation email

Expected Result:

Received one email Verify secondary email

Actual Result:

Validation code is expired. Received email twice: Verify secondary email and a Magic sign-in code

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6560129_1722594456613.Code.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Julesssss]

@arosiclair @dangrous -- I see changes to Auth which seem a likely cause of this regression: https://github.com/Expensify/Auth/pull/11815

This other Web PR could be related Web-E PR, but I think this is less likely than the Auth PR above.

[Julesssss]

I think this is a backend issue. it shouldn't block NewDot. I'm not going to remove the backend deploy blocker label, though, as it might be occurring in OldDot too.

[arosiclair]

@arosiclair @dangrous -- I see changes to Auth which seem a likely cause of this regression: Expensify/Auth#11815

This other Web PR could be related Web-E PR, but I think this is less likely than the Auth PR above.

I'm pretty sure it's unrelated since we didn't change when or how many emails get sent. I'm also seeing duplicate magic code emails on the staging login page as well so there's something else going on:

[dangrous]

yeah i agree with @arosiclair, ours might change the template but wouldn't change the number of emails, as far as I can tell

[Julesssss]

Ah, okay thanks for sharing. I'll keep looking.

[melvin-bot]

Current assignee @Julesssss is eligible for the DeployBlockerCash assigner, not assigning anyone new.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[thienlnam]

Caused by #45395
Fixed in #46846

[trjExpensify]

Thread here in #deployers for reference.

This App PR is the culprit firing off two API calls to RequestContactMethodValidateCode when re-visiting the contact page, so shouldn't be a web deploy blocker.

Reverted it on an adhoc build to test:

2024-08-06_02-20-01.mp4

[marcaaron]

No C+ on this one so gonna close it out.