Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] iOS - Composer - Add attachment modal is hidden behind the keyboard #47925

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 23, 2024 · 10 comments
Closed
1 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to any chat
  3. Focus on the composer (important)
  4. Tap +
  5. Tap Add attachment

Expected Result:

Add attachment modal will not be hidden behind the keyboard

Actual Result:

Add attachment modal is hidden behind the keyboard
Reproducible on devices:
Ihone 14 Pro Max/ios17
iPhone 12 mini iOS 16.7
iPhone 15 Pro Max / iOS 18.0

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6580112_1724400971534.ScreenRecording_08-23-2024_14-13-35_1__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017ff6d7b170a82372
  • Upwork Job ID: 1827036306652595306
  • Last Price Increase: 2024-08-23
Issue OwnerCurrent Issue Owner: @s77rt
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 23, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@marcochavezf marcochavezf added the External Added to denote the issue can be worked on by a contributor label Aug 23, 2024
@melvin-bot melvin-bot bot changed the title iOS - Composer - Add attachment modal is hidden behind the keyboard [$250] iOS - Composer - Add attachment modal is hidden behind the keyboard Aug 23, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017ff6d7b170a82372

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 23, 2024
Copy link

melvin-bot bot commented Aug 23, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@marcochavezf
Copy link
Contributor

I cannot reproduce it on iphone 14 pro max (iOS 17.5.1) in v 9.0.24-1

trim.C09FB6DD-413B-494E-8EA6-31F914AACEB3.MOV

@marcochavezf marcochavezf added Needs Reproduction Reproducible steps needed and removed DeployBlockerCash This issue or pull request should block deployment labels Aug 23, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@marcochavezf marcochavezf added Daily KSv2 and removed Hourly KSv2 labels Aug 23, 2024
@Nodebrute
Copy link
Contributor

@marcochavezf I was able to reproduce the issue on an iPhone 15 Pro Max, but after pulling the latest main branch, the issue is no longer reproducible. It seems that the problem was resolved after reverting #47341

@Nodebrute
Copy link
Contributor

Screen.Recording.2024-08-23.at.11.45.50.PM.mov

@s77rt
Copy link
Contributor

s77rt commented Aug 23, 2024

No reproducible on main (iPhone 15 Pro)

@marcochavezf
Copy link
Contributor

Oh thanks @Nodebrute @s77rt! I will close it out since it's not reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants