[HOLD for payment 2024-09-12][$125] Import categories - GL code field shows undefined when imported category does not have GL code

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Control workspace settings > Categories.
3. Click 3-dot menu.
4. Click Import spreadsheet.
5. Import the following CSV file.
6. Map Name, Enabled and GL code.
7. Click Import.
8. Click on the category that does not have GL code.

Expected Result:

GL code field will be empty.

Actual Result:

GL code field shows undefined.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592371_1725411660406!Independent.-.Multi.Level.tags.csv

Bug6592374_1725411671983.undefined.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831645173273110226
• Upwork Job ID: 1831645173273110226
• Last Price Increase: 2024-09-05

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

GL code field shows undefined.

What is the root cause of that problem?

The value of categoriesGLCode?.[containsHeader ? index + 1 : index] here can be undefined and then when we convert the JSON to string, the GL code that we pass to the API is undefined string then BE returns the wrong GL code.

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 95 in 562d7b4

'GL Code': categoriesGLCodeColumn !== -1 ? categoriesGLCode?.[containsHeader ? index + 1 : index] : '',

What changes do you think we should make in order to solve the problem?

We should fall back to empty string here

'GL Code': categoriesGLCodeColumn !== -1 ? categoriesGLCode?.[containsHeader ? index + 1 : index] ?? '' : '',

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 95 in 562d7b4

'GL Code': categoriesGLCodeColumn !== -1 ? categoriesGLCode?.[containsHeader ? index + 1 : index] : '',

What alternative solutions did you explore? (Optional)

[mountiny]

cc @filip-solecki @rushatgabhane @rlinoz coming from the import spreadsheet PR

[mountiny]

This indeed feels like a blocker for the feature, not demoting. Added @rushatgabhane as he reviewed the original PR #47827

[filip-solecki]

@nkdengineer's proposal looks good

[mountiny]

@nkdengineer are you able to raise the PR soon? thanks!

[nkdengineer]

@mountiny sure, will raise the PR soon.

[nkdengineer]

@mountiny The PR is here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831645173273110226

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

this is super minor fix of a deploy blocker so reducing the bounty to reflect the complexity.

Payment summary:

• $125 to @nkdengineer
• No payment to Rushat as he will be paid on the project basis

[melvin-bot]

@rushatgabhane, @mountiny, @muttmuure, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[rlinoz]

This is in prod already #48539 (comment)

Just waiting payment date, let me update the title.

Oh, payment is actually due today?

[melvin-bot]

@rushatgabhane, @mountiny, @muttmuure, @nkdengineer 10 days overdue. I'm getting more depressed than Marvin.

[muttmuure]

Invite here: https://www.upwork.com/ab/applicants/1831645173273110226/1836111748014972928

[melvin-bot]

@rushatgabhane, @mountiny, @muttmuure, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?

[nkdengineer]

@muttmuure I've accepted the invitation

[muttmuure]

Offer sent

[nkdengineer]

@muttmuure Accepted thx

[muttmuure]

Paid