iOS - Import spreadsheet - Offline modal does not show up on iOS app only

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings > Categories.
3. Go offline.
4. Tap 3-dot button.
5. Tap Import spreadsheet.

Expected Result:

Offline modal will show up.

Actual Result:

Offline modal does not show up on iOS app only.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592801_1725450547719.ScreenRecording_09-04-2024_19-44-09_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Import spreadsheet - Offline modal does not show up on iOS app only

What is the root cause of that problem?

We are not using Modal.close here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 306 in 7aae842

setIsOfflineModalVisible(true);

What changes do you think we should make in order to solve the problem?

We can do something like this here .This is the same way we do it here

             Modal.close(() =>setIsOfflineModalVisible(true));

Optionally we can also add

 onCancel={() => setIsOfflineModalVisible(false)}

What alternative solutions did you explore? (Optional)

[ishpaul777]

Edited by proposal-police: This proposal was edited at {current_timestamp}.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Import spreadsheet - Offline modal does not show up on iOS app only

What is the root cause of that problem?

The general pattern is when a new modal is opened we first need to close all other modals in App using Modal.close
which is not followed here.

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 305 to 311 in 7aae842

	if (isOffline) {
	setIsOfflineModalVisible(true);
	return;
	}
	Navigation.navigate(ROUTES.WORKSPACE_CATEGORIES_IMPORT.getRoute(policyId));
	},
	},

What changes do you think we should make in order to solve the problem?

We should add a prop shouldCallAfterModalHide to isOffline to this menuitem

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 302 to 310 in 7aae842

	icon: Expensicons.Table,
	text: translate('common.importSpreadsheet'),
	onSelected: () => {
	if (isOffline) {
	setIsOfflineModalVisible(true);
	return;
	}
	Navigation.navigate(ROUTES.WORKSPACE_CATEGORIES_IMPORT.getRoute(policyId));
	},

[MonilBhavsar]

New feature, and only happening on iOS for offline flow. Not a blocker

[MonilBhavsar]

Coming from #47827 cc @filip-solecki @rushatgabhane
If you could please make a follow up

[filip-solecki]

Hi! I am Filip from SWM and I'd like to work on this as it comes from my PR

[hoangzinh]

Hi @MonilBhavsar, because it ran over regression period, should @rushatgabhane continue to take this issue as a C+ or can I proceed with the PR above?

[melvin-bot]

This issue has not been updated in over 15 days. @MonilBhavsar, @kadiealexander, @filip-solecki eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!