Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tags - App freezes when clicking checkbox in subtag list #48675

Closed
2 of 6 tasks
IuliiaHerets opened this issue Sep 6, 2024 · 10 comments
Closed
2 of 6 tasks

Multi tags - App freezes when clicking checkbox in subtag list #48675

IuliiaHerets opened this issue Sep 6, 2024 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.30-4
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Workspace is connected to QBO, or have multi tags set up.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.
  3. Click on any main tag.
  4. Click Select all checkbox.

Expected Result:

App will not freeze.

Actual Result:

App freezes when clicking checkbox in subtag list.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6594680_1725574350967.freeze.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 6, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@hoangzinh
Copy link
Contributor

This might be a regression from #46788. This change caused this regression issue

const {shouldUseNarrowLayout} = useResponsiveLayout();

cc @rayane-djouah @getusha

@rayane-djouah
Copy link
Contributor

Thanks @hoangzinh, I will raise a follow-up PR to fix it

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Sep 6, 2024
@rayane-djouah
Copy link
Contributor

rayane-djouah commented Sep 6, 2024

@getusha PR ready for review

This comment was marked as off-topic.

@rayane-djouah
Copy link
Contributor

The fix was CPed to staging

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 9, 2024
@techievivek
Copy link
Contributor

Closing this since it was a regression and is fixed and CPed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants