[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] Sign up - No error indicating that magic code is incorrect when validating account via Wallet

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.44-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): yonghongkok2+dsposjpds@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account.
3. Complete onboarding.
4. Go to Account settings > Wallet.
5. Click Add bank account.
6. Enter incorrect magic code.

Expected Result:

There will be error indicating that the magic code is incorrect.

Actual Result:

There is no error indicating that the magic code is incorrect.
Nothing happens after entering incorrect magic code.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6623233_1727962472420.no_error.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[drminh2807]

Edited by proposal-police: This proposal was edited at 2024-10-03 14:56:37 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Sign up - No error indicating that magic code is incorrect when validating account via Wallet

What is the root cause of that problem?

Wrong reason for clear error

What changes do you think we should make in order to solve the problem?

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 128 to 134 in cb58008

	useEffect(() => {
	if (!validateError) {
	return;
	}
	clearError();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [clearError, validateError]);

always clearError when mount, no add validateError to dependencies

    useEffect(() => {
        clearError();
        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

What alternative solutions did you explore? (Optional)

NA

[jasperhuangg]

This is a bug that wasn't caught during review in #49230

[jasperhuangg]

cc @daledah Are you available to fix this?

[jasperhuangg]

cc @arosiclair @jjcoffee

[jasperhuangg]

The PR causes another blocker, but I think it would be better to fix than revert since the PR is so large.

[daledah]

@jasperhuangg I'll open a follow-up PR soon.

[jasperhuangg]

@daledah Thanks! Please address #50153 in your followup as well.

[arosiclair]

I can takeover on this one. @daledah do you think you can clean up these blockers today?

The PR causes another blocker, but I think it would be better to fix than revert since the PR is so large.

It's not a big deal to revert IMO. If we can't fix these before today's deploy, I think we should just go ahead and revert and clean everything up later.

[daledah]

@arosiclair Thanks for your help! I'm drafting a PR right now. Gonna take around 15 mins to finish things up.

[daledah]

@jasperhuangg Here's the draft PR. You can take a look while I'm uploading the screenshots.

[arosiclair]

Fix is merged and CP'd. I'm going to close this in favor of #50153. We'll handle Ishpaul's payment there

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: error not shown, redirect incorrectly on add bank account #50171

If no regressions arise, payment will be issued on 2024-10-11. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: error not shown, redirect incorrectly on add bank account #50171

If no regressions arise, payment will be issued on 2024-10-14. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@arosiclair] Determine if we should create a regression test for this bug.
• [@arosiclair] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: