Opening a unknown report from the URL displays a blank chat page and no error - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in with any account
2. Navigate to a conversation
3. In the URL, change the report number to something random

Expected Result:

There should be an error about being unable to navigate to that report and user should be redirected to last chat.

Actual Result:

Blank conversation is displayed.

Workaround:

N/A.

Platform:

Where is this issue occurring?

• Web
• Mobile Web

Version Number: 1.1.8-0

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634244884298600

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Proposal

1. Current code handles the empty param but it does not handle reports that do not exist.
   

   App/src/pages/home/ReportScreen.js

   Line 150 in dcfde19

   if (_.isNaN(reportID)) {

2. We should check if the report prop contains data such as reportID. If it does not have that data it means that report does not exists and then we should run the same logic as it does now.

3. I don't think a call to the backend is needed to check if the report exists are all the reports are synced on Onyx before the screen is loaded.

[NikkiWines]

👍 Looks good for UpWork, I agree with @parasharrajat. I don't think we need a call to the backend for this.

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Oops, seemed to have missed this. Sorry! Removed the n6-hold. Upwork job is here.

[MelvinBot]

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[deetergp]

Let's go with @parasharrajat proposal. The this.props.report.reportID property is present for valid reportIDs and not present for invalid ones so it seems like a solid check and the right place to do it.

[parasharrajat]

Ok. Thanks @Beamanator . I will look into different ways.

[parasharrajat]

Haven't found anything on the first look. I will try to find one as soon as possible. Def, not a priority.

[deetergp]

No updates to report.

[deetergp]

No updates. Since this is apparently not a priority, I'm going to bump it down to Monthly.

[deetergp]

Where are we at with this? Is it still an issue?

[parasharrajat]

I think it is. I will try to find a solution to this problem. Adding to my Todo...

[trjExpensify]

Any movement here?

[parasharrajat]

Nope. We should export it again. I don't see any way to fix it atm. You can remove the report by me from the issue details and just reopen it for the start price. I can review the proposals as C+.

[deetergp]

@trjExpensify Let's put this one back in the Exported pool and see if we get another bite.

[trjExpensify]

👋 Sorry for the slow response, I've been OoO. Going back to the OP for a sec:

Action Performed:
Log in with any account
Navigate to a conversation
In the URL, change the report number to something random

Expected Result:
There should be an error about being unable to navigate to that report and user should be redirected to last chat.

I follow those steps and I get this error message when changing the reportID to something random. I'm navigated back to the reportID I was previously on before amending it:

So what's the bug here, this is the expected result no? If that's the case, then I think we close this issue out.

[parasharrajat]

Yup, if this is working then we can close it.

[trjExpensify]

So to confirm, that is the expected result here right? Do you want to just confirm the same result as I got above and then we can close it out.

[tomivs]

So to confirm, that is the expected result here right? Do you want to just confirm the same result as I got above and then we can close it out.

That's right, @trjExpensify. If you check App/src/libs/actions/Reports.js (line 385-390), you'll see that this scenario is already being handled using handleInaccessibleReport().

App/src/libs/actions/Report.js

Lines 429 to 436 in ad637d3

	.catch((err) => {
	if (err.message !== CONST.REPORT.ERROR.INACCESSIBLE_REPORT) {
	return;
	}
	// eslint-disable-next-line no-use-before-define
	handleInaccessibleReport();
	});

And that function is defined as follows (line 1500-1506):

App/src/libs/actions/Report.js

Lines 1500 to 1506 in ad637d3

	/**
	* Handle the navigation when report is inaccessible
	*/
	function handleInaccessibleReport() {
	Growl.error(Localize.translateLocal('notFound.chatYouLookingForCannotBeFound'));
	navigateToConciergeChat();
	}

So, it will throw an error and redirect to Concierge (as you showed). In my opinion, this issue can be closed.

[trjExpensify]

Awesome, sounds good! Closing it out 👍