Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb/Safari - Security - Close account button hidden by keyboard #7572

Closed
kbecciv opened this issue Feb 4, 2022 · 26 comments
Closed

mWeb/Safari - Security - Close account button hidden by keyboard #7572

kbecciv opened this issue Feb 4, 2022 · 26 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Feb 4, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open IOS app
  2. Navigate to Settings >Security > Close account

Expected Result:

''Close account'' button should be fully visible

Actual Result:

''Close account'' button hidden by keyboard

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.36.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5438389_mWeb_7512-0402.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title mWeb/Safari - Security - Clouse account button hidden by keyboard mWeb/Safari - Security - Close account button hidden by keyboard Feb 4, 2022
@TomatoToaster
Copy link
Contributor

I have a feeling that this is a limitation of how the keyboard works in safari mWeb, but I'm not entirely sure. I'll ask somewhere to double check if we want to fix this.

@TomatoToaster
Copy link
Contributor

Ah ok I see on iOS though that it fully brings the button up, it's a much better experience. Going to mark this as external and see if someone has a solution for this.

@TomatoToaster TomatoToaster added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2022
@MelvinBot
Copy link

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot
Copy link

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

Still overdue 6 days?! Let's take care of this!

@MelvinBot
Copy link

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@adelekennedy
Copy link

Oh just seeing this - did you mean to unassign me @TomatoToaster or should I open a job for this?

@MelvinBot MelvinBot removed the Overdue label Feb 17, 2022
@MelvinBot
Copy link

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

Eep! 4 days overdue now. Issues have feelings too...

@MelvinBot
Copy link

Still overdue 6 days?! Let's take care of this!

@MelvinBot
Copy link

12 days overdue now... This issue's end is nigh!

@MelvinBot MelvinBot added Weekly KSv2 and removed Daily KSv2 labels Mar 7, 2022
@MelvinBot
Copy link

This issue has not been updated in over 14 days. eroding to Weekly issue.

@MelvinBot MelvinBot removed the Overdue label Mar 7, 2022
@MelvinBot MelvinBot removed the Weekly KSv2 label Mar 30, 2022
@kbecciv kbecciv reopened this Oct 1, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2022
@JmillsExpensify JmillsExpensify added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 Overdue labels Oct 18, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@puneetlath
Copy link
Contributor

Assigning over to @JmillsExpensify since this is part of the Keyboard project.

@JmillsExpensify JmillsExpensify changed the title mWeb/Safari - Security - Close account button hidden by keyboard [HOLD #10273] mWeb/Safari - Security - Close account button hidden by keyboard Oct 19, 2022
@JmillsExpensify
Copy link

Thanks, I added this to the related tracking issue and I've put this issue on hold. I'll work on retesting everything once Tim's PRs hit staging.

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

@JmillsExpensify
Copy link

Still on hold pending the linked issue.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 26, 2022
@tgolen tgolen self-assigned this Oct 31, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 31, 2022

This is no longer on hold and can have proposals created for it with the new code.

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2022
@tgolen tgolen changed the title [HOLD #10273] mWeb/Safari - Security - Close account button hidden by keyboard mWeb/Safari - Security - Close account button hidden by keyboard Oct 31, 2022
@JmillsExpensify
Copy link

I actually can't reproduce this issue anymore.

@JmillsExpensify
Copy link

This was the flow I followed:

  1. Sign into the app on Mobile Web
  2. Navigate to Settings >Security > Close account
  3. Tap the email field.

As expected, the close account button appears above the keyboard.

@JmillsExpensify
Copy link

I'm going to close this issue as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants