Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android -Notification- Tapping the notification does not open the correct chat #9179

Closed
kbecciv opened this issue May 26, 2022 · 46 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@kbecciv
Copy link

kbecciv commented May 26, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Close NewDot app.
  3. Wait for ~5 minutes.
  4. Send a message from B to A. A push notification should appear
  5. After about 10 seconds, put the device on airplane mode. Passed
  6. Double-tap the notification

Expected Result:

Double-tap the notification. It should open NewDot to the correct chat, and the new message should be available.

Actual Result:

Tapping the notification does not open the correct chat when the app is closed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.67.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+cbecciv@applause.expensifail.com/Feya86Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220526-082055_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 26, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 26, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title Android/IOS -Notification- Tapping the notification does not open the correct chat Android -Notification- Tapping the notification does not open the correct chat May 26, 2022
@Julesssss
Copy link
Contributor

At first glance it doesn't look like any of the PRs could have introduced this... Next step is to check the previous fix to confirm when this regression occurred.

@Julesssss Julesssss self-assigned this May 26, 2022
@pecanoro
Copy link
Contributor

@Julesssss I was trying to reproduce this and the funny thing is that I don't get any push notifications at all in Android, I tried a few times and nothing.

@Julesssss
Copy link
Contributor

Julesssss commented May 26, 2022

Android notifications have been flakey for a while for me. Usually I can get them to work if I log out of web, log out of mobile and then sign in again on the mobile app.

(Just commuting home, then I'll try myself)

@AndrewGable
Copy link
Contributor

I think this is specific to offline mode and we should put it on hold or close it until we are done with offline first refactoring. If this occurs during online mode, then we can look into it as a deploy blocker.

@AndrewGable
Copy link
Contributor

Also this seems like a duplicate of #8963

@pecanoro
Copy link
Contributor

I don't get notifications half of the time. Anyways, when they do, regarding opening the right chat, it hasn't been working for me in months though, but again, not sure if that's the case for everyone.

@AndrewGable
Copy link
Contributor

You shouldn't get notifications when you are "online" on web or have very recently used another client, so I am not sure if your behavior is a bug or expected. I added logic to go to the correct report, but have not seen a video of it not working while online, so if you could reproduce that would be good to know!

@pecanoro
Copy link
Contributor

I am logging out from my desktop before testing notifications. When notifications don't work, I have to do what Jules suggested, log out from my account on mobile too and then log in again. But after a while, they stop showing, well, it's more like hit or miss because sometimes I get them. Let me send record a video about it. But again, this might be happening only to me since I had this problem for months, so not a deploy blocker. Someone else with an Android could test too I guess.

@AndrewGable AndrewGable added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels May 26, 2022
@AndrewGable
Copy link
Contributor

Agreed not a deploy blocker

@Julesssss Julesssss removed their assignment May 26, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2022
@pecanoro
Copy link
Contributor

pecanoro commented Jun 3, 2022

Anyways, since this is related to offline mode, I am going to close it!

@kbecciv
Copy link
Author

kbecciv commented Nov 11, 2022

Issue is reproduced with build 1.2.27.0

Record_2022-11-11-19-06-38_4f9154176b47c00da84e32064abf1c48.mp4

@kbecciv kbecciv reopened this Nov 11, 2022
@melvin-bot melvin-bot bot added the Overdue label Mar 9, 2023
@pecanoro
Copy link
Contributor

pecanoro commented Mar 9, 2023

The issue that we were waiting for has been merged so we can reopen this one to see if it is still reproducible

@melvin-bot melvin-bot bot removed the Overdue label Mar 9, 2023
@pecanoro pecanoro changed the title [HOLD #256638] Android -Notification- Tapping the notification does not open the correct chat Android -Notification- Tapping the notification does not open the correct chat Mar 9, 2023
@pecanoro pecanoro added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. and removed Monthly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 9, 2023
@MelvinBot
Copy link

Current assignee @lschurr is eligible for the Bug assigner, not assigning anyone new.

@MelvinBot
Copy link

MelvinBot commented Mar 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@pecanoro
Copy link
Contributor

pecanoro commented Mar 9, 2023

Trying to replicate this again...

@pecanoro
Copy link
Contributor

pecanoro commented Mar 9, 2023

It does not open the chat indeed, it opens the LHN for me if I click while being offline.

@pecanoro pecanoro added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 9, 2023
@Prince-Mendiratta
Copy link
Contributor

@pecanoro I'm unable to reproduce it on latest prod build from play store on Android 13, followed the steps correctly except double tapping the notification, my phone is too responsive, opens the app on first tap :face-palm:.

Is it necessary to double tap the notification to reproduce this?

@pecanoro
Copy link
Contributor

I didn't double-tap, but I made sure my phone was offline/plane mode before opening the notification.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@pecanoro
Copy link
Contributor

If Applause can't reproduce it either, let's close it then and we can reopen if at some point this comes back.

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2023
@kbecciv
Copy link
Author

kbecciv commented Jun 15, 2023

Issue is reproductible on build 1.3.28.3

Screen_Recording_20230615_212411_New.Expensify.mp4

@kbecciv kbecciv reopened this Jun 15, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 15, 2023
@pecanoro
Copy link
Contributor

@kbecciv Can you open a new issue for this? It seems it's not exactly the same issue as I see in the video that this is happening even while being online.

@melvin-bot melvin-bot bot removed the Overdue label Jun 15, 2023
@kbecciv
Copy link
Author

kbecciv commented Jun 15, 2023

Sure, will do!

@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@pecanoro
Copy link
Contributor

Closing per the above comment! We are creating a new issue as the bug is not the same.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

13 participants