Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-09-26] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here #9739

Closed
mvtglobally opened this issue Jul 6, 2022 · 62 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. Send https://www.expensify.com/inbox or link
  3. Or go to concierge chat as it contains old :expensify: links

Expected Result:

You should see underline below the link and tooltip when you hover

Actual Result:

You don't see any tooltip or underline

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79-11
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-06-25.at.12.41.08.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1656098692618689

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jul 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2022

Triggered auto assignment to @muttmuure (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 6, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Jul 8, 2022
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jul 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 8, 2022

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mountiny
Copy link
Contributor

mountiny commented Jul 8, 2022

This definitely seems as a suitable External issue

@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2022
@puneetlath
Copy link
Contributor

Upwork job is here: https://www.upwork.com/jobs/~0123b2819ac262a34e

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2022

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here [$250] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here Jul 11, 2022
@jeet-dhandha
Copy link
Contributor

A request, can any one provide old and new link in below comment ?

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 30, 2022
@puneetlath
Copy link
Contributor

@parasharrajat @mananjadhav I've sent you both hiring offers through Upwork. Please accept when you get a chance so that we can pay you out. Thanks!

@parasharrajat
Copy link
Member

Let's hold the payment, there is a issue in my last PR implementation. I have already created a PR with the fix that needs to be reviewed.

@melvin-bot

This comment was marked as outdated.

@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2022

@puneetlath, @mananjadhav, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

@parasharrajat
Copy link
Member

Not yet ready for payment. There is another PR waiting to be reviewed.

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 8, 2022

@puneetlath, @mananjadhav, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 9, 2022

@puneetlath, @mananjadhav, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Sep 13, 2022

@puneetlath, @mananjadhav, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@parasharrajat
Copy link
Member

parasharrajat commented Sep 13, 2022

PR is awaiting review. #10503

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 13, 2022
@puneetlath puneetlath changed the title [HOLD for payment 2022-08-30] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here [HOLD for payment 2022-09-21] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here Sep 15, 2022
@puneetlath
Copy link
Contributor

Looks like that PR was merged yesterday. Will pay this out in 6 days if no more regressions.

@melvin-bot melvin-bot bot removed the Overdue label Sep 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

@puneetlath, @mananjadhav, @parasharrajat Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Overdue Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2022
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2022-09-21] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here [HOLD for payment 2022-09-26] [HOLD for payment 2022-09-21] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here Sep 19, 2022
@melvin-bot melvin-bot bot removed the Overdue label Sep 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.1-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-09-26. 🎊

@puneetlath puneetlath changed the title [HOLD for payment 2022-09-26] [HOLD for payment 2022-09-21] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here [HOLD for payment 2022-09-26] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here Sep 19, 2022
@puneetlath
Copy link
Contributor

@mananjadhav - paid.
@parasharrajat - hiring offer sent
@Puneet-here - it doesn't look like you were paid for reporting. If not, can you apply here? https://www.upwork.com/jobs/~01af2bac857d001e72

@Puneet-here
Copy link
Contributor

Applied! Thanks.

@puneetlath
Copy link
Contributor

All paid! Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants