Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web/Chrome - Broken emoji under Frequently used section #9917

Closed
kbecciv opened this issue Jul 14, 2022 · 12 comments
Closed

Web/Chrome - Broken emoji under Frequently used section #9917

kbecciv opened this issue Jul 14, 2022 · 12 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensifail.com
  2. Log in with applausetester+0901abb@applause.expensifail.com/ Feya86Katya
  3. Select Chat Kate Becciv and Click in Emoji

Expected Result:

Correct emoji should be displayed

Actual Result:

Broken emoji under Frequently used section

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.84.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/ Feya87Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
Emojies

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2022

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Beamanator
Copy link
Contributor

@kbecciv I wasn't able to log in with that account :(

Screen Shot 2022-07-15 at 10 25 33 AM

@Beamanator
Copy link
Contributor

I searched through my emojis and couldn't figure out which one that is - can you try to insert the broken one into a chat and then copy / paste it here maybe? 🤔

@Beamanator Beamanator added Weekly KSv2 and removed Daily KSv2 labels Jul 15, 2022
@kbecciv
Copy link
Author

kbecciv commented Jul 15, 2022

@Beamanator Sorry, I was testing something yesterday and changed my password. Please try again this credentials:
applausetester+0901abb@applause.expensifail.com/Feya86Katya

@mvtglobally
Copy link

@luacmartins
Copy link
Contributor

@Beamanator
Copy link
Contributor

Hmm ok so I wonder if there was some weird bug but now it's fixed? I set my NVP to an empty array and now it seems it's working... I will ask around to see if others fix it with this - if so, I may write a CQ to clear out everyone's NVP (since our App is just in beta still)

@luacmartins
Copy link
Contributor

luacmartins commented Jul 19, 2022

@Beamanator well this PR was deployed 22h ago, which should have fixed this. In my initial implementation of getUserDetails I used Onyx merge instead of set as a method for frequently used emojis. That caused the array to be duplicated endlessly on each start / reconnect of the app 😅 I believe this was a front-end only issue, so a CQ shouldn't be necessary.

@melvin-bot melvin-bot bot added the Overdue label Jul 27, 2022
@Beamanator
Copy link
Contributor

Didn't get to this today, will look into it tomorrow or next week

@melvin-bot melvin-bot bot removed the Overdue label Jul 28, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@luacmartins
Copy link
Contributor

I think we can close this. We didn't manage to repro last week!

@Beamanator
Copy link
Contributor

Yeah I agree, we can reopen if someone produces later 🤷

@Beamanator Beamanator closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants