Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Accessing non-existent property 'INVALID_ALT_NUMBER'" warning #551

Closed
palfrey opened this issue Jul 28, 2020 · 4 comments
Closed

"Accessing non-existent property 'INVALID_ALT_NUMBER'" warning #551

palfrey opened this issue Jul 28, 2020 · 4 comments

Comments

@palfrey
Copy link

palfrey commented Jul 28, 2020

Every time I run sushi I get the following warning twice.

(node:39554) Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency

I don't think it's caused any issues, but looks like it should be at least looked at. Upstream bug is antlr/antlr4#2834

@cmoesel
Copy link
Member

cmoesel commented Jul 28, 2020

Hi @palfrey -- thanks for reporting this. We especially appreciate the link to the upstream bug report! We'll keep an eye on that report and upgrade ANTLR once a new version is released.

BTW -- we're currently targeting Node LTS versions, so if you want the most well tested experience of SUSHI, I'd recommend Node 12.x for now...

@palfrey
Copy link
Author

palfrey commented May 11, 2021

antlr/antlr4#2931 should fix this, and got released as antlr 4.9

@cmoesel
Copy link
Member

cmoesel commented May 11, 2021

Yes, we saw that... but unfortunately, antlr 4.9 has breaking changes (apparently they do not follow semantic versioning). The most concerning for us is that antlr 4.9 requires Node 14 (it fails in Node 12). So given the choice between:

  1. Keep antlr 4.8; which works in Node 12 and Node 14 (but logs harmless warnings in Node 14), OR
  2. Move to antlr 4.9 and break SUSHI for all people / systems currently using Node 12

we're currently opting to keep antlr 4.8 for now.

@cmoesel
Copy link
Member

cmoesel commented Jul 5, 2024

This is no longer an issue since SUSHI now requires Node 18.

@cmoesel cmoesel closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants