Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float default value is an int, causing crashes #89

Open
gamma-delta opened this issue Nov 8, 2022 · 7 comments
Open

Float default value is an int, causing crashes #89

gamma-delta opened this issue Nov 8, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@gamma-delta
Copy link

Hello,

People have been getting a lot of issues like this on Hexcasting: https://pastebin.com/Bbb3GWib

io.github.fablabsmc.fablabs.api.fiber.v1.exception.FiberConversionException: Invalid serialized value 0

The rub here is that, in the hexcasting-client.json5 config, it is set to 0.5.

Is this an issue on my side? Here's the line where it's crashing in Hexcasting. (Note there's a Mth.clamp that should fix up issues where Fiber successfully loads a 0 value.)

@gamma-delta
Copy link
Author

@ProfanedBane
Copy link

ProfanedBane commented Nov 9, 2022

Might have found a fix, it's seemingly caused by the version of Java that the Curse Launcher shipped, getting players to change to Adoptium openJDK resolves it.

@gamma-delta
Copy link
Author

Yahoo what a blast

I'm gonna leave this open in case there's something the Fiber people can do about it also but thanks for the fix!

@iepathos
Copy link

Still an issue with latest java for me

@ProfanedBane
Copy link

Still an issue with latest java for me

What Java vendor are you using?

@iepathos
Copy link

I tried Adoptium openJDK 17.0.5.8

@ProfanedBane
Copy link

Good to know that rules it out as a 100% fix, I've had it work on the 3 or so people I've had test it so far so I was unaware it might not work for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants