From 27eb3c1283f6cf70c5b6ce70defe51e4389321e4 Mon Sep 17 00:00:00 2001
From: Cowtowncoder <tatu.saloranta@iki.fi>
Date: Fri, 7 Nov 2014 15:16:45 -0800
Subject: [PATCH] Implement #164

---
 release-notes/VERSION                         |  2 ++
 .../fasterxml/jackson/core/JsonGenerator.java | 33 +++++++++++++++++--
 .../jackson/core/json/JsonWriteContext.java   |  4 +--
 3 files changed, 35 insertions(+), 4 deletions(-)

diff --git a/release-notes/VERSION b/release-notes/VERSION
index b17c717afe..9cc4420ad3 100644
--- a/release-notes/VERSION
+++ b/release-notes/VERSION
@@ -3,6 +3,8 @@ Version: 2.5.0 (xx-xxx-2014)
 
 #148: BytesToNameCanonicalizer can mishandle leading null byte(s).
  (reported by rjmac@github)
+#164: Add `JsonGenerator.Feature.IGNORE_UNKNOWN` (but support via individual
+  data format modules)
 - Added `ResolvedType.getParameterSource()` to support better resolution
  of generic types.
 
diff --git a/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java b/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java
index d7b1b5af4e..38a6727511 100644
--- a/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java
+++ b/src/main/java/com/fasterxml/jackson/core/JsonGenerator.java
@@ -144,6 +144,12 @@ public enum Feature {
          * if format uses escaping mechanisms (which is generally true
          * for textual formats but not for binary formats).
          *<p>
+         * Note that this setting may not necessarily make sense for all
+         * data formats (for example, binary formats typically do not use
+         * any escaping mechanisms; and some textual formats do not have
+         * general-purpose escaping); if so, settings is simply ignored.
+         * Put another way, effects of this feature are data-format specific.
+         *<p>
          * Feature is disabled by default.
          */
         ESCAPE_NON_ASCII(false),
@@ -158,11 +164,35 @@ public enum Feature {
          *<p>
          * Note that enabling this feature will incur performance overhead
          * due to having to store and check additional information.
+         *<p>
+         * Feature is disabled by default.
          * 
          * @since 2.3
          */
         STRICT_DUPLICATE_DETECTION(false),
-            ;
+
+        /**
+         * Feature that determines what to do if the underlying data format requires knowledge
+         * of all properties to output, and if no definition is found for a property that
+         * caller tries to write. If enabled, such properties will be quietly ignored;
+         * if disabled, a {@link JsonProcessingException} will be thrown to indicate the
+         * problem.
+         * Typically most textual data formats do NOT require schema information (although
+         * some do, such as CSV), whereas many binary data formats do require definitions
+         * (such as Avro, protobuf), although not all (Smile, CBOR, BSON and MessagePack do not).
+         *<p>
+         * Note that support for this feature is implemented by individual data format
+         * module, if (and only if) it makes sense for the format in question. For JSON,
+         * for example, this feature has no effect as properties need not be pre-defined.
+         *<p>
+         * Feature is disabled by default, meaning that if the underlying data format
+         * requires knowledge of all properties to output, attempts to write an unknown
+         * property will result in a {@link JsonProcessingException}
+         *
+         * @since 2.5
+         */
+        IGNORE_UNKNOWN(false),
+        ;
 
         private final boolean _defaultState;
 
@@ -1565,5 +1595,4 @@ protected void _writeSimpleObject(Object value)  throws IOException
         throw new IllegalStateException("No ObjectCodec defined for the generator, can only serialize simple wrapper types (type passed "
                 +value.getClass().getName()+")");
     }    
-
 }
diff --git a/src/main/java/com/fasterxml/jackson/core/json/JsonWriteContext.java b/src/main/java/com/fasterxml/jackson/core/json/JsonWriteContext.java
index 1226e28940..1642238e38 100644
--- a/src/main/java/com/fasterxml/jackson/core/json/JsonWriteContext.java
+++ b/src/main/java/com/fasterxml/jackson/core/json/JsonWriteContext.java
@@ -112,7 +112,7 @@ public JsonWriteContext createChildObjectContext() {
      *
      * @return Index of the field entry (0-based)
      */
-    public final int writeFieldName(String name) throws JsonProcessingException {
+    public int writeFieldName(String name) throws JsonProcessingException {
         _gotName = true;
         _currentName = name;
         if (_dups != null) { _checkDup(_dups, name); }
@@ -123,7 +123,7 @@ private final void _checkDup(DupDetector dd, String name) throws JsonProcessingE
         if (dd.isDup(name)) { throw new JsonGenerationException("Duplicate field '"+name+"'"); }
     }
     
-    public final int writeValue() {
+    public int writeValue() {
         // Most likely, object:
         if (_type == TYPE_OBJECT) {
             _gotName = false;