Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology construction for 1D elements is broken #684

Closed
AbdAlazezAhmed opened this issue Apr 24, 2023 · 2 comments · Fixed by #670
Closed

Topology construction for 1D elements is broken #684

AbdAlazezAhmed opened this issue Apr 24, 2023 · 2 comments · Fixed by #670
Assignees
Labels

Comments

@AbdAlazezAhmed
Copy link
Collaborator

AbdAlazezAhmed commented Apr 24, 2023

Topology construction seems to be broken for 1D elements.

julia> grid = generate_grid(Line,(3,))
Grid{1, Line, Float64} with 3 Line cells and 4 nodes

julia> topo = ExclusiveTopology(grid)
ERROR: MethodError: no method matching edges(::Line)
Closest candidates are:
  edges(::Interpolation{2}) at C:\Users\Abdul\.julia\dev\Ferrite\src\interpolations.jl:44
  edges(::Interpolation) at deprecated.jl:70
  edges(::Quadrilateral) at C:\Users\Abdul\.julia\dev\Ferrite\src\Grid\grid.jl:217
  ...
Stacktrace:
 [1] ExclusiveTopology(cells::Vector{Line})
   @ Ferrite C:\Users\Abdul\.julia\dev\Ferrite\src\Grid\grid.jl:405
 [2] ExclusiveTopology(grid::Grid{1, Line, Float64})
   @ Ferrite C:\Users\Abdul\.julia\dev\Ferrite\src\Grid\grid.jl:478
 [3] top-level scope
   @ REPL[3]:1

I made a workaround while working on sparsity patterns for DG.

@koehlerson
Copy link
Member

koehlerson commented May 5, 2023

either #670 needs to include a regression test, then it can be closed, or otherwise close after adding regression test

@termi-official
Copy link
Member

Done in linked PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants