Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove INSTANCE_CACHE from dynamic_link branch #295

Closed
loloicci opened this issue Apr 20, 2023 · 1 comment
Closed

remove INSTANCE_CACHE from dynamic_link branch #295

loloicci opened this issue Apr 20, 2023 · 1 comment
Assignees

Comments

@loloicci
Copy link
Contributor

INSTANCE_CACHE is a thread-local variable used in some tests for old dynamic link way.

thread_local! {
// INSTANCE_CACHE and MODULE_CACHE are intended to replace wasmvm's cache layer in the mock.
// Unlike wasmvm, you have to initialize them yourself in the place where you test the dynamic call.
pub static INSTANCE_CACHE: RwLock<HashMap<String, RefCell<MockInstance>>> = RwLock::new(HashMap::new());
pub static MODULE_CACHE: RwLock<HashMap<String, RefCell<Module>>> = RwLock::new(HashMap::new());
}

But, it is not used after #273. So This should be removed.

@loloicci
Copy link
Contributor Author

closed via #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant