Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix inconsistent comment for dividePoint() #769

Merged

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Mar 18, 2024

Description

  • (audit issue) fix comment by hiding details.
    • Problem: The divider is assigned with math.MaxInt64 + 1 which does not align with the comment x÷(MaxUint64+1)×y.
      • Comment: // dividePoint computes x÷(MaxUint64+1)×y without overflow for uint64. ...
      • Actual code: math.MaxInt64 + 1

@jaeseung-bae jaeseung-bae self-assigned this Mar 18, 2024
@jaeseung-bae jaeseung-bae added the C: documentation Classification: Improvements or additions to documentation label Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.57%. Comparing base (1279868) to head (f89862b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   66.52%   66.57%   +0.05%     
==========================================
  Files         285      285              
  Lines       37917    37917              
==========================================
+ Hits        25224    25243      +19     
+ Misses      10887    10868      -19     
  Partials     1806     1806              
Files Coverage Δ
types/validator_set.go 91.13% <ø> (ø)

... and 14 files with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review March 18, 2024 07:43
@ulbqb ulbqb self-requested a review March 19, 2024 01:58
@jaeseung-bae jaeseung-bae merged commit c6e5b1f into Finschia:main Mar 19, 2024
23 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/inconsistency-code-and-comment branch March 19, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: documentation Classification: Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants