Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply the wasm module of lbm-sdk(dynamic_link branch) #18

Merged
merged 8 commits into from
Apr 12, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Mar 28, 2023

Description

Applied the x/wasm module of the dynamic link branch of the lbm-sdk(Finschia/finschia-sdk#936).

Finschia/finschia-sdk@main...dynamic_link
The above changes have been added and modified and URL, etc. have been updated.

When Finschia/wasmvm#94 is merged, update commit-hash and add CHANGELOG.

  • commit-hash
  • CHANGELOG

Differences from dynamic link branch in lbm-sdk

Basically, I follow #1 (comment).

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 self-assigned this Mar 28, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analizer.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found 24 existing alerts. Please check the repository Security tab to see all alerts.

@da1suk8 da1suk8 marked this pull request as ready for review March 29, 2023 02:11
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #18 (5247508) into dynamic_link (cae21ec) will increase coverage by 0.16%.
The diff coverage is 93.10%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           dynamic_link      #18      +/-   ##
================================================
+ Coverage         60.89%   61.05%   +0.16%     
================================================
  Files                62       62              
  Lines              8405     8427      +22     
================================================
+ Hits               5118     5145      +27     
+ Misses             2989     2984       -5     
  Partials            298      298              
Impacted Files Coverage Δ
x/wasm/types/store.go 0.00% <ø> (ø)
x/wasm/keeper/api.go 95.34% <93.10%> (+12.99%) ⬆️

@Kynea0b
Copy link

Kynea0b commented Apr 6, 2023

About description.

The above changes have been added and modified and PATH, etc. have been updated.

What does PATH mean?

Kynea0b
Kynea0b previously approved these changes Apr 6, 2023
loloicci
loloicci previously approved these changes Apr 6, 2023
@da1suk8
Copy link
Member Author

da1suk8 commented Apr 7, 2023

@kokeshiM0chi

What does PATH mean?

PATH is URL.
The description is rewritten to the URL.

This means the following modifications.
lbm-sdk -> wasmd
types "github.com/line/lbm-sdk/x/wasm/types" -> types "github.com/line/wasmd/x/wasm/types"

@Kynea0b
Copy link

Kynea0b commented Apr 11, 2023

Thank you for your explanation!

@da1suk8 da1suk8 dismissed stale reviews from loloicci and Kynea0b via 9b42e46 April 11, 2023 10:03
@da1suk8 da1suk8 merged commit 050408a into Finschia:dynamic_link Apr 12, 2023
@da1suk8 da1suk8 deleted the apply_dynamiclink_changes branch April 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants