Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade callEnd button when call is ended #181

Closed
6 of 7 tasks
Melr0k opened this issue May 2, 2024 · 1 comment
Closed
6 of 7 tasks

Fade callEnd button when call is ended #181

Melr0k opened this issue May 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Melr0k
Copy link

Melr0k commented May 2, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.
  • I optionally donated to support the Fossify mission.

Feature description

Fade the callEnd button when the phone call is ended. Why not fade the others as they should not be enabled too…

Why do you want this feature?

When a phone call ends I don't really understand why it stays there for a bit before the call activity closes. And in this moment I always doubt if the phone call is really ended or not, and it took some time to see the text "Call ended".
I think it's more clear to fade/dim the buttons to reassures that the phone call is ended. And it's easy to do.

Additional information

I tried binding.callEnd.setAlpha(0.5f) in the method endCall from CallActivity (line 759, just before the if statement) and I like it.
It probably should be in its own function so we can visually disable all the buttons we decide to fade.

@Melr0k Melr0k added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels May 2, 2024
@Aga-C Aga-C added enhancement New feature or request and removed feature request Issue is about a new feature in the app labels May 3, 2024
@naveensingh naveensingh removed the needs triage Issue is not yet ready for PR authors to take up label May 4, 2024
@naveensingh
Copy link
Member

Should be fixed in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants