Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gas_price_service): refactor service initialisation in sub_services module #2184

Closed
1 task done
rymnc opened this issue Sep 11, 2024 · 1 comment · Fixed by #2256
Closed
1 task done

chore(gas_price_service): refactor service initialisation in sub_services module #2184

rymnc opened this issue Sep 11, 2024 · 1 comment · Fixed by #2256
Assignees
@rymnc
Labels
good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@rymnc
Copy link
Member

rymnc commented Sep 11, 2024 •
edited
Loading

ref: #2163 (comment)

need to re-architect the gas price service initialisation by hiding gas price algorithm details etc.

InitializeTask can be a RunnableService, but GasPriceService should only implement RunnableTask. Try to use TaskParams for initialization, and handle sub service lifecycle within GasPriceService

Definition of done

  • gas price service is initialised in the sub_services module, and all its internal details are abstracted away.
@rymnc rymnc added tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. good first issue Good for newcomers labels Sep 11, 2024
@rymnc rymnc mentioned this issue Sep 11, 2024
Merged
9 tasks
@rymnc rymnc linked a pull request Sep 13, 2024 that will close this issue
chore(gas_price_service): refactor gas price service #2192
Closed
9 tasks
@rymnc rymnc self-assigned this Sep 16, 2024
@rymnc rymnc mentioned this issue Sep 16, 2024
Closed
9 tasks
@rymnc rymnc linked a pull request Sep 27, 2024 that will close this issue
chore(gas_price_service): split into v0 and v1 and squash FuelGasPriceUpdater type into GasPriceService #2256
Merged
9 tasks
@rymnc
Copy link
Member Author

rymnc commented Oct 2, 2024

addressed in #2256

@rymnc rymnc closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymnc rymnc

Labels
good first issue Good for newcomers tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
1 participant
@rymnc