Use max_fee policy to charge user

[MitchTurner]

No description provided.

[MitchTurner]

This was on the Miro board, but I'm not sure what it means :P

[xgreenx]

The current codebase converts max_gas into max_fee and deducts this amount from available balances.

It was okay to do because gas_price was statically defined by the transaction itself. But in a new module, since the base gas price is dynamic, the max_fee based on the max_gas is dynamic too. Instead of using this dynamic value, we need to use max_fee defined by the user in the policies if it is available.

[MitchTurner]

Are we keeping script_gas_limit? I'm still confused about the relationship between gas limit and max_fee.

[Voxelot]

yes we need to keep script_gas_limit as a way for users to budget how much of their fee goes into script execution vs witness data etc