From e427b8252f2c8d05f787976993ef832d0084c845 Mon Sep 17 00:00:00 2001 From: GPortas Date: Fri, 24 Mar 2023 17:20:54 +0000 Subject: [PATCH] Added: explicitly setting false value for testing disabled feature flags --- .../iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java | 1 + .../edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java b/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java index 9a931eca69f..477f8ee377a 100644 --- a/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java +++ b/src/test/java/edu/harvard/iq/dataverse/api/auth/SessionCookieAuthMechanismTest.java @@ -23,6 +23,7 @@ public void setUp() { } @Test + @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "false", varArgs = "api-session-auth") public void testFindUserFromRequest_FeatureFlagDisabled() throws WrappedAuthErrorResponse { sut.session = Mockito.mock(DataverseSession.class); diff --git a/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java b/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java index 22c1cb44606..1a9fdeaa3da 100644 --- a/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java +++ b/src/test/java/edu/harvard/iq/dataverse/settings/FeatureFlagsTest.java @@ -8,12 +8,13 @@ class FeatureFlagsTest { @Test + @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "false", varArgs = "api-session-auth") void testFlagDisabled() { assertFalse(FeatureFlags.API_SESSION_AUTH.enabled()); } @Test - @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "on", varArgs = "api-session-auth") + @JvmSetting(key = JvmSettings.FEATURE_FLAG, value = "true", varArgs = "api-session-auth") void testFlagEnabled() { assertTrue(FeatureFlags.API_SESSION_AUTH.enabled()); }