02 components #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlavioRr
requested review from
AriannFernando,
CristianA01702752,
MandukoGR,
Mike5801 and
AndresMaganaPerez
MandukoGR
previously requested changes
Apr 24, 2023
GomezMorinFrontEnd/src/App.jsx
Outdated
| import IconTitle from "./components/IconTitle" | ||
| import DropdownText from "./components/DropdownText" | ||
|
|
||
|
|
| * @returns {JSX.Element} - The CardImage component JSX element. | ||
| */ | ||
| const CardImage = ({icon}) => { | ||
| return ( |
| * @param {string} icon3 - The url of the third image. | ||
| * @returns {JSX.Element} - The GalleryCard component JSX element. | ||
| */ | ||
| const GalleryCard = ({icon1, icon2, icon3}) => { |
| * @param {string} headerText - The text content for the header. | ||
| * @returns {JSX.Element} - The IconTitle component JSX element. | ||
| */ | ||
| function IconTitle({ image, headerText }) { |
There was a problem hiding this comment.
Usar arrow function: const IconTitle = ({ image, headerText }) => {}
| * @param {string} icon3 - The url of the third image. | ||
| * @returns {JSX.Element} - The GalleryCard component JSX element. | ||
| */ | ||
| const GalleryCard = ({icon1, icon2, icon3}) => { |
There was a problem hiding this comment.
Mejor usen un arreglo de icons y un map
AriannFernando
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
<-- Agregar una descripción concisa de lo que hace el pull request !-->
6 componentes han sido terminados:
CardImage
GalleryCard
TextContainer
TextButton
IconTitle
DropdownText
Resumen de cambios
<-- Enlistar los commits hechos del pull request !-->
4 commits=
Commit inicial = Card Image, GalleryCard y TextButton
2do commit = Text Container
3ro commit = IconTitle
4to commit= DropdownText
Notas (opcional)
<-- Agregar notas para explicar aspectos adicionales del pull request !-->
N/A