01 components #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MandukoGR
reviewed
Apr 24, 2023
MandukoGR
reviewed
Apr 24, 2023
…jsx, import component App.jsx. Comments on checkbox and InfoProfileCard components
…Loader, TextArea)
AriannFernando
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
Se terminó la implementación de los componentes (TextArea, Header, Footer, ProfileCard, CheckBox, InfoProfileCard y SpinnerLoader). Se modificó el package.json para borrar la API de google (Causaba problemas) y se agregaron algunos paquetes de React. Se modificó el Layout para incluir el componente Footer. La page.jsx tiene pruebas que se realizaron para verificar los componentes, puede ser omitida en el PR. Se agregaron imagenes de GM, junto con la Font y los colores.
Resumen de cambios
<-- Enlistar los commits hechos del pull request !-->
-Initial setup to test components
-[TextArea(form) Component added]
-[Fonts]
-[Footer component]
-[Header component complete]
-[JavaDoc in component Header]
-[Checkbox component]
-[Footer Component]
-[Half component InfoProfileCard]
-[update the page file]
-[correct className standard in components]
-[InfoProfileCard Component style]
-[add custom colors to be used]
-[add style to checkbox and definition of custom colors in tailwind config]
-[new component spinner loader]
-[New base images]
-[SpinnerLoader component finished and commented]
-[Commented, variables in english, Add sippinerLoader]
-[Minor changes on comments]
-[Minor comment changes, applied pritier formater to footer]
-[Applied prettier format, Add new subLabel prop to component]
-[Deleting Fer and Cris Components from my branch]
Notas (opcional)
Si se intenta correr la rama probablemente no funcione debido a las dependencias que existen entre los componentes de "00-components". El componente de InfoProfileCard no va a funcionar correctamente hasta que se implementen las querys.