-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidecar mounter grace period #91
Comments
Hi @jadenlemmon , thanks for the question. This is about how the CSI driver handles the grace period. We have two scenarios First scenario If the Pod is a Job Pod or the
As you can see, in this scenario, it does not respect the Second scenario For other workloads, the Pods are supposed to run forever. In this case, if the Pod crashes, it follows the doc Kubernetes best practices: terminating with grace. Specifically,
Going back to your question, yes, for the first scenario, we currently do not allow users to override the 30 sec But I think it's fair to allow user to override the |
@songjiaxun That all makes sense but definitely would be nice to support the override in the meantime. Let me know if I can help in any way. |
@jadenlemmon I created this commit 65d5eca to make the sidecar container respect the Pod In your use case, you will need to specify a small This will be included in the next release. |
In the latest release, the
As a result, it is unnecessary for the sidecar container to wait for the |
First let me say, I'm excited that GKE has native support for this now. I'm excited to use this driver in projects.
I have a question regarding the grace period timeout that happens before the mounter sidecar exists. It seems like it waits 30 seconds before exiting. I'm using this inside of short term workloads and this causes them all to run for an extra 30 seconds.
Looking at the code it seems like it isn't currently overridable. I see there is a
gracePeriod
flag that could be overridden here however the webhook dosen't allow passing in overrides.Is there a reason for not allowing an override there? Would this be something a PR could be accepted for?
I have deployed this driver natively in GKE by using the addons approach.
The text was updated successfully, but these errors were encountered: