Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security vulnerability in dependencies #6

Open
felipemarinho97 opened this issue Jun 20, 2018 · 4 comments
Open

Security vulnerability in dependencies #6

felipemarinho97 opened this issue Jun 20, 2018 · 4 comments
Labels
bug Something isn't working external It was a real bug, but not in the code in this repo.

Comments

@felipemarinho97
Copy link
Member

felipemarinho97 commented Jun 20, 2018

the hoek package has a security vulnerability in 2.16.3 version. It's required by one of angular-cli dependencies, specifically, node-sass @4.9.0, as described here angular/angular-cli#10480 (comment) and seen here sass/node-sass#2355 may we will have to wait until angular-cli update its node-sass dep to v5 to see this problem solved.

@felipemarinho97 felipemarinho97 added bug Something isn't working external It was a real bug, but not in the code in this repo. labels Jun 20, 2018
@felipemarinho97
Copy link
Member Author

Updating @angular-devkit/build-angular to the latest version now fixes the hoek package security vulnerability

@deezone
Copy link

deezone commented Aug 4, 2018

Updating to @angular-devkit/build-angular@0.7.2 still produces the warning on Github

$ npm view @angular-devkit/build-angular version
0.7.2
$ npm list @angular-devkit/build-angular
hb-dashboard-a6@0.0.0 /Users/dee/projects/angular/hydrobytes-dashboard/hb-dashboard-a6
└── @angular-devkit/build-angular@0.7.2

image

image

@felipemarinho97
Copy link
Member Author

@deezone please run npm ls hoek to see what package is requiring hoek.

@felipemarinho97
Copy link
Member Author

Ok, seems that on node-sass it was fixed, the problem now is because node-gyp still requires request less than 2.87.0.

@angular-devkit/build-angular@0.7.2
  └─┬ node-sass@4.9.2
    └─┬ node-gyp@3.7.0
      └─┬ request@2.81.0
        └─┬ hawk@3.1.3
          ├─┬ boom@2.10.1
          │ └── hoek@2.16.3  deduped
          ├── hoek@2.16.3 
          └─┬ sntp@1.0.9
            └── hoek@2.16.3  deduped

This PR nodejs/node-gyp#1471 will fix the problem on node-gyp .

Thank you for your feedback @deezone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external It was a real bug, but not in the code in this repo.
Projects
None yet
Development

No branches or pull requests

2 participants