From 85a5b178844052e820c63d195e21d5b8e8d9d428 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vin=C3=ADcius=20Louren=C3=A7o?= <contact@viniciusl.com.br>
Date: Sun, 17 Sep 2023 20:54:32 -0300
Subject: [PATCH] http2: server add `asyncDispose`

PR-URL: https://github.com/nodejs/node/pull/48548
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
---
 doc/api/http2.md                                 | 12 ++++++++++++
 lib/internal/http2/core.js                       |  5 +++++
 test/parallel/test-http2-server-async-dispose.js | 15 +++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 test/parallel/test-http2-server-async-dispose.js

diff --git a/doc/api/http2.md b/doc/api/http2.md
index 518990a2e9cb8c..d0d019e0040273 100644
--- a/doc/api/http2.md
+++ b/doc/api/http2.md
@@ -2070,6 +2070,17 @@ If `callback` is provided, it is not invoked until all active sessions have been
 closed, although the server has already stopped allowing new sessions. See
 [`net.Server.close()`][] for more details.
 
+#### `server[Symbol.asyncDispose]()`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+Calls [`server.close()`][] and returns a promise that fulfills when the
+server has closed.
+
 #### `server.setTimeout([msecs][, callback])`
 
 <!-- YAML
@@ -4212,6 +4223,7 @@ you need to implement any fall-back behavior yourself.
 [`response.write(data, encoding)`]: http.md#responsewritechunk-encoding-callback
 [`response.writeContinue()`]: #responsewritecontinue
 [`response.writeHead()`]: #responsewriteheadstatuscode-statusmessage-headers
+[`server.close()`]: #serverclosecallback
 [`server.maxHeadersCount`]: http.md#servermaxheaderscount
 [`tls.Server.close()`]: tls.md#serverclosecallback
 [`tls.TLSSocket`]: tls.md#class-tlstlssocket
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
index 92ce193b0078a8..9947246708f19d 100644
--- a/lib/internal/http2/core.js
+++ b/lib/internal/http2/core.js
@@ -28,6 +28,7 @@ const {
   StringPrototypeSlice,
   Symbol,
   SymbolDispose,
+  SymbolAsyncDispose,
   TypedArrayPrototypeGetLength,
   Uint32Array,
   Uint8Array,
@@ -3195,6 +3196,10 @@ class Http2Server extends NETServer {
     validateSettings(settings);
     this[kOptions].settings = { ...this[kOptions].settings, ...settings };
   }
+
+  async [SymbolAsyncDispose]() {
+    return FunctionPrototypeCall(promisify(super.close), this);
+  }
 }
 
 Http2Server.prototype[EventEmitter.captureRejectionSymbol] = function(
diff --git a/test/parallel/test-http2-server-async-dispose.js b/test/parallel/test-http2-server-async-dispose.js
new file mode 100644
index 00000000000000..4782e12e417d27
--- /dev/null
+++ b/test/parallel/test-http2-server-async-dispose.js
@@ -0,0 +1,15 @@
+'use strict';
+
+const common = require('../common');
+
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+
+const http2 = require('http2');
+
+const server = http2.createServer();
+
+server.listen(0, common.mustCall(() => {
+  server.on('close', common.mustCall());
+  server[Symbol.asyncDispose]().then(common.mustCall());
+}));