Add NaN/Inf instrumentation #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
nan-inf-instrumentation
branch
from
b9ca2d5
to
b166ce2
Compare
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Unified global/heap binding to the more generic control/payload structure, to be able to support more kinds of QA instrumentation. Control is intended to be device-local information, and payload is host-visible information. Rather than add more heap bindings, we need to use push descriptors here. Not every shader uses heap bindings, e.g., a shader can rely solely on root descriptors. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
nan-inf-instrumentation
branch
from
b166ce2
to
c9f9d2f
Compare
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Allows flagging type of barrier as well. Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
HansKristian-Work
force-pushed
the
nan-inf-instrumentation
branch
from
162ea8a
to
66d0fc6
Compare
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Signed-off-by: Hans-Kristian Arntzen <post@arntzen-software.no>
doitsujin
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.