Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing a numpy.random.RandomState object as random_state_model in the train functions. #3

Open
mcw92 opened this issue Aug 28, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request Urgency: low

Comments

@mcw92
Copy link
Member

mcw92 commented Aug 28, 2024

Currently, the train functions only accept integers as the model random state in random_state_model as it makes the internal handling of the different RandomState objects eventually required for different ranks in the DistributedRandomForest class easier.
For the data-related random state, each rank needs the same seed / RandomState object which makes it easy to further process a RandomState object passed here. For the model, the original workflow took the model base seed, added the local rank, and turned it into a rank-specific RandomState object which would not work the same if a RandomState object would be passed here. If we would allow passing a RandomState object for the model as well, it could be used to generate either the model base seed (in the case of local model seed = model base seed + rank) or the sequence of comm.size integers used as local seeds.

@mcw92 mcw92 added enhancement New feature or request Urgency: low labels Aug 28, 2024
@mcw92 mcw92 self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Urgency: low
Projects
None yet
Development

No branches or pull requests

1 participant