Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs page lock without owner #15

Closed
hkimura opened this issue May 28, 2015 · 1 comment
Closed

Needs page lock without owner #15

hkimura opened this issue May 28, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@hkimura
Copy link
Collaborator

hkimura commented May 28, 2015

Marked with "// TODO(Hideaki) PAGE LOCK HERE"

In MasstreeComposeContext::install_snapshot_pointers(), we must take a page lock because the page might be split at the moment. For that, we need a page lock without owner.

The plan is to assign either some node or core ID to a special "no-owner".
Waiters then either spin remotely or locally if they observe such ID.
Now that SGI already (wow) has 256 sockets machines, we shouldn't use node ID for this purpose.
I'm sure one node won't have 256 cores, so probably core-ID 255 can be saved for this.

array/hash/sequential don't need this. Only masstree package needs it.

@hkimura hkimura added the bug label May 28, 2015
@hkimura hkimura added this to the First Beta milestone May 28, 2015
@hkimura hkimura self-assigned this May 28, 2015
@hkimura
Copy link
Collaborator Author

hkimura commented Sep 14, 2015

Fixed by #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant